-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues found while importing collection to Automation Hub #57
Comments
@tima - Since https://github.com/ansible-collections/redhat.openshift doesn't exist—which of these options should we choose:
|
For the ansible-doc issue... I wonder if Automation Hub supports cross-collection documentation fragments? I know we are pulling in fragments from kubernetes.core, and maybe that's causing the ansible-doc failure? |
I created a bug in the Automation Hub Jira tracker here: https://issues.redhat.com/browse/AAH-154 |
It looks like the downstream build script has a line:
And that seems like it should take care of at least most of the dependency issues on Automation Hub. But it would still be better to just fix up this collection to depend on kubernetes.core in the first place. |
Created PR #58. |
The documentation issue should be fixed on next release by this PR: #59 However, there could still be some lingering issues to clean up, I'll update this issue once 1.0.1 is released and see what the import log shows. |
Current issues in the AH import (docs issue is resolved, though, yay!):
Import log (might need login to view): https://cloud.redhat.com/ansible/automation-hub/redhat/openshift/import-log?version=1.0.1 |
Fixes: openshift#62 openshift#57 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Fixes: openshift#62 openshift#57 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@geerlingguy #63 resolves all the issues mentioned. Could you please verify this while you import the new release? Thanks, |
@Akasurde - If I pull
Just noting that what I see in the
|
Fixes: openshift#57 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Fixes: #57 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
SUMMARY
When uploading version 1.0.0 of the downstream
redhat.openshift
collection, we ran into a few errors.We should also see if we can get the errors to reproduce in our own automated tests so we don't run into similar errors in the future.
ALSO, I just noticed the
repo
that ends up being referenced is https://github.com/ansible-collections/redhat.openshift, and the issue tracker is https://github.com/ansible-collections/redhat.openshift/issues — neither of which currently exist.ISSUE TYPE
COMPONENT NAME
Automation Hub downstream release.
Related: #51
See release log: https://cloud.redhat.com/ansible/automation-hub/redhat/openshift/import-log?version=1.0.0 (requires authentication).
The text was updated successfully, but these errors were encountered: