Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] tox currently doesn't parse deps with comments well #1973

Closed
1 task
webknjaz opened this issue Apr 14, 2019 · 4 comments · Fixed by #1990
Closed
1 task

[BUG] tox currently doesn't parse deps with comments well #1973

webknjaz opened this issue Apr 14, 2019 · 4 comments · Fixed by #1990
Labels
bug critical

Comments

@webknjaz
Copy link
Member

webknjaz commented Apr 14, 2019 •
edited
Loading

I'll need to check pyup docs on whether we could post that comment one line above or smth.
I've also filed a bug in tox: tox-dev/tox#1260

TODO:

  • restore filters once it's fixed

oh.. this one seems wrong because it's parsed as a single line. we should turn it into a list

Originally posted by @webknjaz in #1958
@webknjaz webknjaz mentioned this issue Apr 15, 2019
Merged
6 tasks
@webknjaz
Copy link
Member Author

tox-dev/tox#1262 will fix this issue once merged.

@webknjaz webknjaz self-assigned this Apr 15, 2019
@decentral1se
Copy link
Contributor

decentral1se commented Apr 16, 2019 •
edited
Loading

OK, this appears to be the reason for our broken CI right now. I assume waiting for a release of Tox will take too long (and them fixing their CI), so let's get a stop gap fix we can put in place now to get us back to a running CI without this issue.

decentral1se added a commit to decentral1se/molecule that referenced this issue Apr 16, 2019
@decentral1se
Remove comment that Tox cannot parse correctly
6b066d7 
An interim fix for ansible#1973.

Signed-off-by: Luke Murphy <lukewm@riseup.net>
@decentral1se decentral1se mentioned this issue Apr 16, 2019
Merged
@decentral1se
Copy link
Contributor

How about #1977 for now?

decentral1se added a commit to decentral1se/molecule that referenced this issue Apr 16, 2019
@decentral1se
Remove comment that Tox cannot parse correctly
d6b597d 
An interim fix for ansible#1973.

Signed-off-by: Luke Murphy <lukewm@riseup.net>
decentral1se added a commit to decentral1se/molecule that referenced this issue Apr 16, 2019
@decentral1se
Remove comments that Tox cannot parse correctly
0702247 
An interim fix for ansible#1973.

Signed-off-by: Luke Murphy <lukewm@riseup.net>
webknjaz pushed a commit that referenced this issue Apr 16, 2019
@decentral1se @webknjaz
Remove comments that Tox cannot parse correctly
346f7de 
An interim fix for #1973.

Signed-off-by: Luke Murphy <lukewm@riseup.net>
gaborbernat pushed a commit to tox-dev/tox that referenced this issue Apr 17, 2019
@webknjaz @gaborbernat
🔥 Cut comments off dependency lines (#1262)
3c6b4f2 
This enables users to have inline comments in deps lines in `tox.ini`. In particular, this allows having pyup bot integration.

Ref: pyupio/dparse#34
Ref: ansible/molecule#1973

Fixes #1260
@webknjaz
Copy link
Member Author

Good news! We'll be able to address this soon!

@webknjaz webknjaz mentioned this issue Apr 17, 2019
Merged
@helpr helpr bot added the pr-available label Apr 17, 2019
@helpr helpr bot added pr-merged and removed pr-available labels Apr 17, 2019
@webknjaz webknjaz removed their assignment May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Fix the CI: remove comment that Tox cannot parse correctly" ansible/molecule
2 participants
@webknjaz @decentral1se