🔥 Cut comments off dependency lines #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
requested changes
Apr 15, 2019
|
@gaborbernat is it fine now? |
1 task
asottile
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
I'm ok signing off on this, I'll let @gaborbernat make the final call though
|
I'll merge it after we fix our CI. |
|
@asottile @gaborbernat thanks! |
|
Please do specify/document the exact behaviour in config.rst under deps. |
|
okay |
|
Thanks for picking this up @webknjaz 🚀 |
gaborbernat
requested changes
Apr 16, 2019
|
master fixed now |
webknjaz
force-pushed
the
bugfix/rm-comments-from-dep-lines
branch
from
43ddf99 to
6410943
Compare
webknjaz
commented
Apr 16, 2019
gaborbernat
force-pushed
the
bugfix/rm-comments-from-dep-lines
branch
5 times, most recently
from
335f248 to
9783de2
Compare
gaborbernat
force-pushed
the
bugfix/rm-comments-from-dep-lines
branch
from
9783de2 to
c3da4b1
Compare
|
Thanks! Can I expect a release soon? |
|
Not much content for a new release 🤔 but why not! |
|
I'd appreciate that since it'd unblock issues in Molecule :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to have inline comments in deps lines in
tox.ini. In particular, this allows having pyup bot integration.Ref: pyupio/dparse#34
Ref: ansible/molecule#1973
Fixes #1260
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,miscsuperuser."CONTRIBUTORS(preserving alphabetical order)