Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency entries with comments are not parsed correctly #1260

Closed
webknjaz opened this issue Apr 14, 2019 · 2 comments · Fixed by #1262
Closed

Dependency entries with comments are not parsed correctly #1260

webknjaz opened this issue Apr 14, 2019 · 2 comments · Fixed by #1262
Labels
feature:new something does not exist yet, but should pr-merged

Comments

@webknjaz
Copy link
Contributor

So the reproducer is

deps = 
    yapf>=0.25.0,<0.27  # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915

And it results in:

ERROR: could not install deps [flake8>=3.6.0,<4, yamllint>=1.11.1,<2, mock==2.0.0, pytest==3.6.0, pytest-cov==2.6.0, pytest-helpers-namespace==2019.1.8, pytest-mock==1.10.0, pytest-verbose-parametrize==1.4.0, pytest-xdist==1.26.0, shade==1.22.2, yapf>=0.25.0,<0.27  # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915, ansible>=2.7,<2.8]; v = InvocationError("/home/travis/build/ansible/molecule/.tox/ansible27-unit/bin/python -m pip install 'flake8>=3.6.0,<4' 'yamllint>=1.11.1,<2' mock==2.0.0 pytest==3.6.0 pytest-cov==2.6.0 pytest-helpers-namespace==2019.1.8 pytest-mock==1.10.0 pytest-verbose-parametrize==1.4.0 pytest-xdist==1.26.0 shade==1.22.2 'yapf>=0.25.0,<0.27  # pyup: < 0.27 # disable updates, conflicts with flake8 as per https://github.com/ansible/molecule/pull/1915' 'ansible>=2.7,<2.8'", 1)

I think that it may be a configparser bug as I recall something like this mentioned in that PEP about selection of config format for pyproject. But it still seems relevant to tox...

@webknjaz webknjaz added the bug:normal affects many people or has quite an impact label Apr 14, 2019
@gaborbernat gaborbernat added feature:new something does not exist yet, but should and removed bug:normal affects many people or has quite an impact labels Apr 15, 2019
@gaborbernat
Copy link
Member

THis is more a feature request than bug 👍

@gaborbernat gaborbernat changed the title [BUG] Dependency entries with comments are not parsed correctly Dependency entries with comments are not parsed correctly Apr 15, 2019
@webknjaz
Copy link
Contributor Author

Well, you probably know better :)

webknjaz added a commit to webknjaz/tox that referenced this issue Apr 15, 2019
@helpr helpr bot added the pr-available label Apr 15, 2019
webknjaz added a commit to webknjaz/tox that referenced this issue Apr 16, 2019
gaborbernat pushed a commit that referenced this issue Apr 17, 2019
This enables users to have inline comments in deps lines in `tox.ini`. In particular, this allows having pyup bot integration.

Ref: pyupio/dparse#34
Ref: ansible/molecule#1973

Fixes #1260
@helpr helpr bot added pr-merged and removed pr-available labels Apr 17, 2019
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature:new something does not exist yet, but should pr-merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants