Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian and Ukrainian translations updated #726

Closed
wants to merge 10 commits into from
Closed

Russian and Ukrainian translations updated #726

wants to merge 10 commits into from

Conversation

likhner
Copy link
Contributor

@likhner likhner commented Dec 12, 2020

No description provided.

Copy link
Contributor

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job — I'd like to clear some linguistic moments though before merging this

Translations/ru.lproj/preferences.strings Outdated Show resolved Hide resolved
Translations/ru.lproj/Localizable.strings Outdated Show resolved Hide resolved
Translations/uk.lproj/Credits.strings Outdated Show resolved Hide resolved
Translations/uk.lproj/Localizable.strings Outdated Show resolved Hide resolved
@aonez aonez self-assigned this Dec 14, 2020
@aonez aonez added this to the 1.2.6 milestone Dec 14, 2020
@aonez
Copy link
Owner

aonez commented Dec 14, 2020

@likhner please check out @NickKaramoff reviews and don't worry too much for the merge conflicts, just be sure to check e3829c5.

Thanks a lot!

Translations/ru.lproj/preferences.strings Outdated Show resolved Hide resolved
@likhner
Copy link
Contributor Author

likhner commented Dec 14, 2020

I think that's all.

@aonez
Copy link
Owner

aonez commented Dec 14, 2020

Thanks a lot to both of you!

@likhner likhner requested a review from aonez December 14, 2020 14:57
@aonez aonez closed this in b0e677c Dec 14, 2020
@aonez
Copy link
Owner

aonez commented Dec 14, 2020

Manually merged (due to conflicts) in b0e677c! Thanks a lot @likhner, @hugonote & @NickKaramoff 💪🏼🔝

aonez added a commit that referenced this pull request Dec 14, 2020
"Tip a coffee" = "Чайові на каву";
"Tip Keka a coffee so it can stay awake" = "Дайте Keka кави, щоб вона могла не спати";
"Tip a breakfast" = "Чайові на сніданок";
"Tip Keka a breakfast so it can start fresh" = "Дайте Keka сніданок, щоб почати все з чистого аркуша";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likhner this one can't be used because exceeds 45 characters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask @hugonote to fix it then (because he does Ukrainian translation). He was just double-checking the current translation. He will also make a new PR as well.

Maybe you should mention in the README about the 45-character limit?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks @likhner! I've added some comments about the limit in the file itself but it's common (and understandable) to skip that comments...

/*
// MAS tips
// Note this will be used in Apple's servers
// Apple needs to have MAS translated in this language so this strings can be used
// The language used in MAS/AppleID will be used in Keka's tip strings and may not match Keka's localization
// Note that the short string is limited to 30 characters and the long string is limited to 45 characters
// Emojis cannot be used in these strings :(
*/
"Monthly sip of coffee" = "Щомісячний ковток кави";
"Gift Keka a sip of coffee each month" = "Подаруйте Keka щомісячний ковток кави";
"Monthly coffee" = "Щомісячна кава";
"Gift Keka a coffee each month" = "Подаруйте Keka щомісячну каву";
"Monthly pair of coffees" = "Щомісячна пара кави";
"Gift Keka a couple coffees each month" = "Подаруйте Keka щомісячну пару кав";
"Monthly breakfast" = "Щомісячний сніданок";
"Gift Keka a breakfast each month" = "Подаруйте Keka щомісячний сніданок";
"Tip a coffee" = "Чайові на каву";
"Tip Keka a coffee so it can stay awake" = "Дайте Keka кави, щоб вона могла не спати";
"Tip a breakfast" = "Чайові на сніданок";
"Tip Keka a breakfast so it can start fresh" = "Дайте Keka сніданок, щоб почати все з чистого аркуша";
"Tip a lunch" = "Чайові на обід";
"Tip Keka a lunch and feed it" = "Дайте Keka обід";
"Tip a dinner" = "Чайові на вечерю";
"Tip Keka a dinner so it keeps rolling" = "Дайте Keka вечерю, щоб продовжувати працювати";
"Tip a bunch of food" = "Дайте на чай купу їжі";
"Tip Keka a new bunch of food to keep rolling" = "Дайте Keka купу їжі, щоб продовжувати працювати";

"Tip a bunch of food" = "Tip a bunch of food";
"Tip Keka a new bunch of food to keep rolling" = "Tip Keka a new bunch of food to keep rolling";
"Tip Keka a new bunch of food to keep rolling" = "Дайте Keka купу їжі, щоб продовжувати працювати";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likhner this one also exceeds 45 characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants