-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian and Ukrainian translations updated #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job — I'd like to clear some linguistic moments though before merging this
Co-authored-by: Nikita Karamov <nick@karamoff.dev>
Co-authored-by: Nikita Karamov <nick@karamoff.dev>
I think that's all. |
Thanks a lot to both of you! |
"Tip a coffee" = "Чайові на каву"; | ||
"Tip Keka a coffee so it can stay awake" = "Дайте Keka кави, щоб вона могла не спати"; | ||
"Tip a breakfast" = "Чайові на сніданок"; | ||
"Tip Keka a breakfast so it can start fresh" = "Дайте Keka сніданок, щоб почати все з чистого аркуша"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@likhner this one can't be used because exceeds 45 characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll ask @hugonote to fix it then (because he does Ukrainian translation). He was just double-checking the current translation. He will also make a new PR as well.
Maybe you should mention in the README about the 45-character limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks @likhner! I've added some comments about the limit in the file itself but it's common (and understandable) to skip that comments...
Keka/Translations/uk.lproj/Localizable.strings
Lines 228 to 253 in 2fc95dd
/* | |
// MAS tips | |
// Note this will be used in Apple's servers | |
// Apple needs to have MAS translated in this language so this strings can be used | |
// The language used in MAS/AppleID will be used in Keka's tip strings and may not match Keka's localization | |
// Note that the short string is limited to 30 characters and the long string is limited to 45 characters | |
// Emojis cannot be used in these strings :( | |
*/ | |
"Monthly sip of coffee" = "Щомісячний ковток кави"; | |
"Gift Keka a sip of coffee each month" = "Подаруйте Keka щомісячний ковток кави"; | |
"Monthly coffee" = "Щомісячна кава"; | |
"Gift Keka a coffee each month" = "Подаруйте Keka щомісячну каву"; | |
"Monthly pair of coffees" = "Щомісячна пара кави"; | |
"Gift Keka a couple coffees each month" = "Подаруйте Keka щомісячну пару кав"; | |
"Monthly breakfast" = "Щомісячний сніданок"; | |
"Gift Keka a breakfast each month" = "Подаруйте Keka щомісячний сніданок"; | |
"Tip a coffee" = "Чайові на каву"; | |
"Tip Keka a coffee so it can stay awake" = "Дайте Keka кави, щоб вона могла не спати"; | |
"Tip a breakfast" = "Чайові на сніданок"; | |
"Tip Keka a breakfast so it can start fresh" = "Дайте Keka сніданок, щоб почати все з чистого аркуша"; | |
"Tip a lunch" = "Чайові на обід"; | |
"Tip Keka a lunch and feed it" = "Дайте Keka обід"; | |
"Tip a dinner" = "Чайові на вечерю"; | |
"Tip Keka a dinner so it keeps rolling" = "Дайте Keka вечерю, щоб продовжувати працювати"; | |
"Tip a bunch of food" = "Дайте на чай купу їжі"; | |
"Tip Keka a new bunch of food to keep rolling" = "Дайте Keka купу їжі, щоб продовжувати працювати"; |
"Tip a bunch of food" = "Tip a bunch of food"; | ||
"Tip Keka a new bunch of food to keep rolling" = "Tip Keka a new bunch of food to keep rolling"; | ||
"Tip Keka a new bunch of food to keep rolling" = "Дайте Keka купу їжі, щоб продовжувати працювати"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@likhner this one also exceeds 45 characters
No description provided.