-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix bulk action annotation #50852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bulk action annotation #50852
Conversation
bf6f3ef to
22f6aba
Compare
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Looks good overall! Small question :)
airflow-core/src/airflow/api_fastapi/core_api/datamodels/common.py
Outdated
Show resolved
Hide resolved
22f6aba to
19a8208
Compare
19a8208 to
15b39cd
Compare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
This is weird, since the |
|
Removing the |
|
Maybe changing the |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action should be required.
|
I've pushed a commit to improve it, let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks, Pierre! Making Literal makes sense and eliminates the stated problem while making them limited to being properly used by the discriminator.
This was exactly what I mentioned in my comment. #50852 (comment).
|
Yes, the tips for it to work was to make the |
edbe4df to
29912bf
Compare
|
Make sense! Thanks for fixing this and the tip is really helpful. |
* Fix bulk api annotation * Small improvement --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com> (cherry picked from commit 3208bbb)
* Fix bulk api annotation * Small improvement --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
* Fix bulk api annotation * Small improvement --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Why
The type annotations for bulk action are incorrect, which is found when I dig into tracing ci error in #50443. I think this is independent thus split this from that one.
How
I update the action type with default value. This would affect bulk connection, variable and pool.
before (example value show on swagger)
after (example value show on swagger)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.