Skip to content

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Jul 28, 2025

closes: #52272

This just fixes the bars. Indeed as mentioned in the related issue we might want to reconsider how we build this because the total number of slots displayed can grow beyond the total pool slots. This is caused by the fact that we display in the same way state that take up a pool slots and those that do not. (QUEUE, RUNNING, OPEN) should always be included, (DEFERRED) should only be included if configured, and SCHEDULED / DEFERRED (if not configured) should probably be displayed outside of that pool occupancy bar, to not confuse users.

This is a bigger effort to improve the UI to not have this confusion anymore and find a way to clearly display the difference between all kind of slots. (also because this component is shared with multiple pools summary) for the short term I just fixed the bar, and will create an issue for the follow up.

Before

Screenshot 2025-07-28 at 17 59 35 Screenshot 2025-07-28 at 17 59 42

After:

Screenshot 2025-07-28 at 17 59 08 Screenshot 2025-07-28 at 17 59 18

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 28, 2025
@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.4 milestone Jul 28, 2025
@pierrejeambrun pierrejeambrun mentioned this pull request Jul 28, 2025
1 task
@pierrejeambrun
Copy link
Member Author

Follow up issue:
#53826

@pierrejeambrun
Copy link
Member Author

cc: @uranusjr just in case you have time to double check that this fixes it on your side.

@pierrejeambrun pierrejeambrun merged commit e83ca8e into apache:main Jul 28, 2025
54 checks passed
@pierrejeambrun pierrejeambrun deleted the fix-pool-bar branch July 28, 2025 19:08
@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Jul 28, 2025
@github-actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker e83ca8e v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@pierrejeambrun
Copy link
Member Author

No need to backport, v3-0-test branch does not have the problem.

Screenshot 2025-07-29 at 11 47 17

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jul 31, 2025
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pool view bar does not display counts well

2 participants