Download task logs #54481
Closed
Download task logs #54481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#53943) * Fix redacted values editing * Small improvements * Small adjustments * Update UI and fix some errors * Address PR comments
Add path existence check to bundle initialization to help users identify configuration issues early. When a bundle is initialized but its path doesn't exist on disk, Airflow now logs a clear warning message indicating the missing path and potential DAG loading issues. This improves the debugging experience for users setting up DAG bundles by providing immediate feedback when bundle paths are misconfigured.
* i18n(Ko): add missing translations * Fix translation for "Dag Run ID" to "Dag 실행 ID"
…he#53990) Enhanced error handling in the AWS Lambda executor to better distinguish between Lambda service failures (DLQ) and task execution failures. Added check to properly identify DLQ failures and updated error messages to clearly indicate whether the failure was at the Lambda service level (timeout/crash/memory) or during task execution.
…e_version set (apache#53952) Fix dag_versions property when created_dag_version is None with bundle_version set
…he#53995) This will land in 3.0.4, not 3.1.0.
…54014) - The previously used `google._upb._message.ScalarMapContainer` is not available in protobuf >= 5.*, which breaks RayHook and operators. Co-authored-by: Oleg Kachur <kachur@google.com>
* fix typo in http conn docs * fix typo in conn docs
) When we reach timeut we kill all the hanging containers already and after the pool has been terminated, we will print all the logs. However, when the pool had not yet been fully executing (i.e the containers were hanging and some tasks were not started) - without terminating the pool that would kill running containers and the remaining tasks would start new ones. This PR changes the timeout handler to terminate the pool before attempting to kill all the containers. It also turned out that exit handling by the main thread monitorint the tests in this case would hang rather than print logs: * it was waiting in a loop to wait for all task to complete (which would never happen) * it was trying to retrieve result from ApplyResult without timeout where it would hang for ever for terminated tasks This PR introduces a separate path to handle timeout, which does not wait for those two and handles timeout immediately. It also refactors the whole "end of tests" method splitting it into several methods to make it easier to reason and read.
collinmcnulty
requested review from
BasPH,
Fokko,
Lee-W,
XD-DENG,
bbovenzi,
bolkedebruin,
bugraoz93,
dstandish,
eladkal,
ephraimbuddy,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham,
jscheffl,
mobuchowski,
o-nikolas,
pierrejeambrun,
potiuk,
rawwar,
romsharon98,
ryanahamilton,
shahar1,
shubhamraj-git,
uranusjr and
vincbeck
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to download task instance logs in airflow 3 ui as described in issue #47689
closes: #47689
Duplicates and rebases #49412 which appears abandoned