feat(ui): implement dynamic legend system for calendar #55155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyLee1224
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
pierrejeambrun
approved these changes
Sep 2, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice, tested locally and working. That's a cool addition.
Just a few suggestion, mainly to make the code more readable because there is a lot of computation, cases to handle and it can be hard to read in the current state.
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/Calendar.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/calendarUtils.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/pages/Dag/Calendar/calendarUtils.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @pierrejeambrun, I've pushed the updates addressing your comments. The code should be cleaner now. Please let me know what you think. Thanks! |
bbovenzi
approved these changes
Sep 3, 2025
RoyLee1224
added a commit
to RoyLee1224/airflow
that referenced
this pull request
Sep 12, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* feat(ui): implement dynamic legend system for calendar * refactor(ui): simplify calendar data handling * refactor(ui): extract calendar color constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54951
Summary
Replaced the hardcoded color scale in the Calendar view with a dynamic system. The new scale is generated based on the true min/max of the data.
Key Changes:
Dynamic Legend: The legend now intelligently adjusts its labels and display type (gradient vs. single value) to match the data distribution.
Fixes Low-Variance Display: Correctly handles cases where run counts are uniform (e.g., all days have 5 runs). The view now shows an appropriate medium-intensity color and a single-value legend, instead of a misleading maximum color.
Screenshots:
dynamic_legend.mp4
UI in different scenario (with mock data)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.