[v3-1-test] fix: Enable real-time extra links updates for TriggerDagRunOperator (#59507) #60225
+40
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unOperator (#59507) * fix: Enable real-time extra links updates for TriggerDagRunOperator - Add smart polling to ExtraLinks component using useAutoRefresh hook - Poll automatically when DAG is active and links are not yet available - Stop polling once extra links appear to reduce server load - Respects global auto_refresh_interval config and DAG paused state - Fixes issue where Triggered DAG button only appeared after manual refresh Closes #58928 * fix: prevent infinite polling for tasks without extra links - Add task metadata check using useTaskServiceGetTask - Only poll if task.extra_links.length > 0 - Conditionally render ExtraLinks component in Details.tsx - Prevents unnecessary API calls for tasks without extra links Addresses review feedback from @bbovenzi * refactor: reuse parent refetchInterval pattern in child components - Pass parent's refetchInterval to ExtraLinks and BlockingDeps components - Remove duplicate useAutoRefresh and useTaskServiceGetTask calls - Eliminate invalid taskInstance.extra_links property access (doesn't exist on TaskInstanceResponse) - Polling now tied to try instance pending state - stops automatically when task completes - Simplifies architecture by centralizing refresh logic in parent component Addresses review feedback from @pierrejeambrun and @bbovenzi * style: apply pre-commit hook formatting fixes - Reorder type union to alphabetical order (number | false) - Format ExtraLinks component to single line (cherry picked from commit 2768fba) Co-authored-by: subhash-0000 <122723782+subhash-0000@users.noreply.github.com>
12 tasks
bbovenzi
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58928
Addresses review feedback from @bbovenzi
Addresses review feedback from @pierrejeambrun and @bbovenzi
(cherry picked from commit 2768fba)
Co-authored-by: subhash-0000 122723782+subhash-0000@users.noreply.github.com