Skip to content

[v3-1-test] fix: Enable real-time extra links updates for TriggerDagRunOperator (#59507) #60225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbovenzi merged 1 commit into from
Jan 7, 2026
Merged

[v3-1-test] fix: Enable real-time extra links updates for TriggerDagRunOperator (#59507) #60225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions airflow-core/src/airflow/ui/src/pages/TaskInstance/BlockingDeps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,25 @@ import { useTranslation } from "react-i18next";
import { useTaskInstanceServiceGetTaskInstanceDependencies } from "openapi/queries";
import type { TaskInstanceResponse } from "openapi/requests/types.gen";

export const BlockingDeps = ({ taskInstance }: { readonly taskInstance: TaskInstanceResponse }) => {
type BlockingDepsProps = {
readonly refetchInterval: number | false;
readonly taskInstance: TaskInstanceResponse;
};

export const BlockingDeps = ({ refetchInterval, taskInstance }: BlockingDepsProps) => {
const { t: translate } = useTranslation();
const { data } = useTaskInstanceServiceGetTaskInstanceDependencies({
dagId: taskInstance.dag_id,
dagRunId: taskInstance.dag_run_id,
mapIndex: taskInstance.map_index,
taskId: taskInstance.task_id,
});
const { data } = useTaskInstanceServiceGetTaskInstanceDependencies(
{
dagId: taskInstance.dag_id,
dagRunId: taskInstance.dag_run_id,
mapIndex: taskInstance.map_index,
taskId: taskInstance.task_id,
},
undefined,
{
refetchInterval,
},
);

if (data === undefined || data.dependencies.length < 1) {
return undefined;
Expand Down
7 changes: 5 additions & 2 deletions airflow-core/src/airflow/ui/src/pages/TaskInstance/Details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,14 @@ export const Details = () => {
taskInstance={taskInstance}
/>
)}
<ExtraLinks />
<ExtraLinks refetchInterval={isStatePending(tryInstance?.state) ? refetchInterval : false} />
{taskInstance === undefined ||
// eslint-disable-next-line unicorn/no-null
![null, "queued", "scheduled"].includes(taskInstance.state) ? undefined : (
<BlockingDeps taskInstance={taskInstance} />
<BlockingDeps
refetchInterval={isStatePending(tryInstance?.state) ? refetchInterval : false}
taskInstance={taskInstance}
/>
)}
{taskInstance !== undefined && (taskInstance.trigger ?? taskInstance.triggerer_job) ? (
<TriggererInfo taskInstance={taskInstance} />
Expand Down
24 changes: 17 additions & 7 deletions airflow-core/src/airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,26 @@ import { useParams } from "react-router-dom";

import { useTaskInstanceServiceGetExtraLinks } from "openapi/queries";

export const ExtraLinks = () => {
type ExtraLinksProps = {
readonly refetchInterval: number | false;
};

export const ExtraLinks = ({ refetchInterval }: ExtraLinksProps) => {
const { t: translate } = useTranslation("dag");
const { dagId = "", mapIndex = "-1", runId = "", taskId = "" } = useParams();

const { data } = useTaskInstanceServiceGetExtraLinks({
dagId,
dagRunId: runId,
mapIndex: parseInt(mapIndex, 10),
taskId,
});
const { data } = useTaskInstanceServiceGetExtraLinks(
{
dagId,
dagRunId: runId,
mapIndex: parseInt(mapIndex, 10),
taskId,
},
undefined,
{
refetchInterval,
},
);

return data && Object.keys(data.extra_links).length > 0 ? (
<Box py={1}>
Expand Down