Use FixedSizeListArray::new in FixedSizeListBuilder #5612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 9, 2024
| len, | ||
| n.len(), | ||
| ))); | ||
| let len = match s { |
There was a problem hiding this comment.
This is the fix for #5614
tustvold
commented
Apr 9, 2024
| @@ -662,7 +662,7 @@ mod tests { | |||
| ); | |||
|
|
|||
| let list = FixedSizeListArray::new(field.clone(), 0, values.clone(), None); | |||
| assert_eq!(list.len(), 6); | |||
| assert_eq!(list.len(), 0); | |||
There was a problem hiding this comment.
This is technically incorrect, in a FixedSizeListArray with size 0, the length of the values has no bearing on the length of the array
I've created #5615 to track that it isn't possible to create a non-empty, non-nullable FixedSizeListArray with size 0.
crepererum
approved these changes
Apr 9, 2024
alamb
reviewed
Apr 9, 2024
| let array_data = unsafe { array_data.build_unchecked() }; | ||
|
|
||
| FixedSizeListArray::from(array_data) | ||
| FixedSizeListArray::new(field, self.list_len, values, nulls) |
There was a problem hiding this comment.
It is great to use consolidate the validation logic 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5614
Rationale for this change
Follow up to #5541 that avoids some code duplication
What changes are included in this PR?
Are there any user-facing changes?