WIP: limited eslint-* update for evaluation only #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: エリス <ellis.bryan@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
brodycj
changed the title
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 65.62% 65.62%
=======================================
Files 14 14
Lines 1702 1702
Branches 286 286
=======================================
Hits 1117 1117
Misses 585 585Continue to review full report at Codecov.
|
1 task
|
Is this still WIP? |
|
Yes and I will need a couple weeks or so to look at this one. I wouldn't mind if someone else wants to make a new, updated PR. |
|
Closing in favor #496 which is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
For evaluation and discussion only (raised from a -alt-wip branch):
What testing has been done on this change?
npm testitems pass on Travis CIChecklist
Reported an issue in the JIRA databaseCommit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.Added automated test coverage as appropriate for this change.