Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: major eslint updates (with eslint-config-standard@next) for evaluation only #390

Closed
wants to merge 1 commit into from

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Aug 2, 2018

Platforms affected

iOS

What does this PR do?

WIP for evaluation & discussion only (with an alt-wip branch name):

cannot be backported to 4.5.x since it requires minimum Node.js 6

Alternative using eslint@4, not using alpha eslint-config-standard@next version, is in #389.

What testing has been done on this change?

  • check that npm test items pass on Travis CI

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   65.62%   65.62%           
=======================================
  Files          14       14           
  Lines        1702     1702           
  Branches      286      286           
=======================================
  Hits         1117     1117           
  Misses        585      585

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f628f61...b6f3da6. Read the comment docs.

@brodycj brodycj mentioned this pull request Aug 3, 2018
1 task
"eslint-plugin-standard": "^3.0.1",
"eslint": "^5.2.0",
"eslint-config-semistandard": "^12.0.1",
"eslint-config-standard": "^12.0.0-alpha.0",
Copy link
Member

@erisu erisu Aug 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that this one has to be on @next?
Could it be eslint-config-standard@^11.0.0 as seen in the other evaluation PR #389 while the rest were updated?

I don't see any problems with updating all of them. I prefer this PR. (+1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-config-standard@next was needed to resolve an ugly warning message from eslint@5, details are now in the description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI ^12.0.0-alpha.0 means that we would use the -alpha version until the publish a newer version, such as -beta, or finally publish 12.0.0 version

@brodycj
Copy link
Contributor Author

brodycj commented Aug 3, 2018

To clarify the general question: I would generally favor upgrading to "latest" version of dependencies and devDependencies whenever possible when targeting upcoming major release. The problem is that using eslint@latest would lead to the ugly warning as discussed in the updated description and review comments unless we would use eslint-config-standard@next (eslint-config-standard@^12.0.0-alpha.0). We are basically stuck waiting for eslint-config-standard@12.0.0 to be released as discussed in standard/eslint-config-standard#123.

I think we should not introduce "@next" dependency version unless absolutely necessary for some reason.

@shazron
Copy link
Member

shazron commented Jan 9, 2019

Is this still WIP? There are conflicts that need to be resolved.

@erisu
Copy link
Member

erisu commented Jan 18, 2019

Closing in favor #496 which is now merged.

@erisu erisu closed this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants