Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Platform Release Preparation (Cordova 9) #496

Merged
merged 10 commits into from
Jan 17, 2019
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 16, 2019

Platforms affected

ios

What does this PR do?

This PR contains final preparations for the Cordova 9 release goals.

See Cordova 9 Release Plan.

  • Bumped Dependencies
    • cordova-common@^3.1.0
    • ios-sim@^7.0.0
    • xcode@1.1.0
    • q@^1.5.1
    • nopt@^4.0.1
    • plist@^3.0.1
  • Bumped ESLint dependencies with correction
    • eslint@^5.12.0
    • eslint-config-semistandard@^13.0.0
    • eslint-config-standard@^12.0.0
    • eslint-plugin-import@^2.14.0
    • eslint-plugin-node@^8.0.1
    • eslint-plugin-promise@^4.0.1
    • eslint-plugin-standard@^4.0.0
  • Updated Dev Dependencies
    • Bumped tmp@0.0.33
    • Dropped nodeunit
    • Bumped nyc@^13.1.0

What testing has been done on this change?

  • npm t
    • Unit Testing
    • Component Testing
    • Object-C Testing
    • E2E Testing
    • Code Coverage
    • ESLinting
  • Travis CI
  • AppVeyor
  • Platform Tests
    $ npx cordova@nightly create iosTest com.foobar.iosTest
    $ npx cordova@nightly platform add github:erisu/cordova-ios\#cordova9-prep
    $ npx cordova@nightly run ios
    $ npx cordova@nightly build ios
    

@erisu
Copy link
Member Author

erisu commented Jan 16, 2019

Remaining Task

  • Update Cordova dependency xcode@^2.0.0 once released.

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #496 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines        1822     1822           
=======================================
  Hits         1362     1362           
  Misses        460      460
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/build.js 51.79% <0%> (ø) ⬆️
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.2% <100%> (ø) ⬆️
bin/templates/scripts/cordova/lib/Podfile.js 73.02% <100%> (ø) ⬆️
bin/templates/scripts/cordova/lib/prepare.js 83.89% <100%> (ø) ⬆️
...in/templates/scripts/cordova/lib/BridgingHeader.js 95.52% <57.14%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cab27...9f750d4. Read the comment docs.

@erisu erisu mentioned this pull request Jan 16, 2019
33 tasks
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brodycj
Copy link
Contributor

brodycj commented Jan 18, 2019

Thanks!

@erisu erisu deleted the cordova9-prep branch April 4, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants