[fix](variant)fix variant type conflicts in nested types #52696

amorynan · 2025-07-02T15:01:42Z

What problem does this PR solve?

fix variant type conflicts with scalar and array
fix multi-level array can be parse into variant which should be report as error
fix convert_field_to_type convert_numric_type do not use PrimitiveType
add UT for function_cast :: FromVariant
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-07-02T15:01:47Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

be/src/vec/columns/column_variant.cpp

eldenmoon · 2025-07-02T15:11:35Z

run buildall

be/src/vec/functions/function_cast.h

be/src/vec/json/json_parser.cpp

doris-robot · 2025-07-02T15:41:15Z

TPC-H: Total hot run time: 33668 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 69600e9067934e34d5c64659f0122d50fece4ab1, data reload: false

------ Round 1 ----------------------------------
q1	17618	5171	5007	5007
q2	1916	286	200	200
q3	10342	1279	701	701
q4	10259	1010	510	510
q5	8181	2325	2316	2316
q6	183	160	127	127
q7	866	743	606	606
q8	9307	1233	1072	1072
q9	6780	5095	5112	5095
q10	6904	2394	1952	1952
q11	505	280	277	277
q12	342	349	218	218
q13	17793	3625	3049	3049
q14	221	224	220	220
q15	558	466	473	466
q16	417	421	372	372
q17	577	847	357	357
q18	7389	7118	7157	7118
q19	1279	917	529	529
q20	327	332	211	211
q21	3661	2559	2321	2321
q22	1028	1008	944	944
Total cold run time: 106453 ms
Total hot run time: 33668 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5547	5092	5100	5092
q2	237	319	211	211
q3	2107	2630	2258	2258
q4	1396	1788	1372	1372
q5	4142	4340	4496	4340
q6	217	169	125	125
q7	2052	1939	1816	1816
q8	2599	2603	2575	2575
q9	7254	7273	7139	7139
q10	3164	3334	2926	2926
q11	577	536	500	500
q12	686	769	662	662
q13	3548	3887	3254	3254
q14	291	334	280	280
q15	527	484	476	476
q16	435	519	462	462
q17	1184	1541	1607	1541
q18	7576	7855	7645	7645
q19	792	845	943	845
q20	1918	1938	1790	1790
q21	4678	4155	4211	4155
q22	1108	1010	986	986
Total cold run time: 52035 ms
Total hot run time: 50450 ms

doris-robot · 2025-07-02T15:52:45Z

TPC-DS: Total hot run time: 181615 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 69600e9067934e34d5c64659f0122d50fece4ab1, data reload: false

query1	996	381	382	381
query2	6538	1659	1651	1651
query3	6733	215	213	213
query4	26003	23882	22899	22899
query5	4370	579	414	414
query6	296	205	187	187
query7	4621	478	281	281
query8	273	218	226	218
query9	8578	2633	2647	2633
query10	471	317	267	267
query11	15494	14974	14932	14932
query12	157	111	105	105
query13	1643	534	384	384
query14	8967	5556	5582	5556
query15	207	186	162	162
query16	7339	607	454	454
query17	1175	719	575	575
query18	2022	377	293	293
query19	187	185	159	159
query20	120	114	115	114
query21	210	118	98	98
query22	4019	4213	4122	4122
query23	33696	32898	33077	32898
query24	8433	2357	2380	2357
query25	552	472	386	386
query26	1230	258	147	147
query27	2772	491	350	350
query28	4346	2122	2095	2095
query29	747	549	433	433
query30	289	214	183	183
query31	893	844	727	727
query32	70	65	59	59
query33	549	359	301	301
query34	774	827	511	511
query35	758	816	754	754
query36	948	959	869	869
query37	111	97	76	76
query38	4105	4172	4062	4062
query39	1457	1404	1407	1404
query40	213	122	134	122
query41	55	54	50	50
query42	131	108	103	103
query43	477	513	450	450
query44	1306	827	816	816
query45	174	171	167	167
query46	818	998	636	636
query47	1735	1810	1697	1697
query48	380	409	307	307
query49	737	486	377	377
query50	611	697	401	401
query51	4139	4124	4039	4039
query52	109	101	94	94
query53	222	247	185	185
query54	581	562	506	506
query55	82	80	79	79
query56	285	298	297	297
query57	1162	1175	1136	1136
query58	255	243	253	243
query59	2590	2685	2519	2519
query60	326	328	331	328
query61	147	144	143	143
query62	806	710	654	654
query63	221	188	194	188
query64	4428	1095	745	745
query65	4280	4170	4160	4160
query66	1156	418	320	320
query67	15802	15525	15440	15440
query68	8619	876	524	524
query69	487	298	268	268
query70	1182	1066	1103	1066
query71	438	317	283	283
query72	5703	2324	5159	2324
query73	811	742	354	354
query74	9216	9203	8709	8709
query75	3943	3172	2668	2668
query76	3594	1129	704	704
query77	826	371	289	289
query78	10118	10320	9424	9424
query79	1892	820	588	588
query80	586	510	445	445
query81	483	253	221	221
query82	442	126	90	90
query83	246	246	223	223
query84	242	100	83	83
query85	788	361	309	309
query86	333	295	302	295
query87	4376	4511	4295	4295
query88	3244	2289	2293	2289
query89	388	308	289	289
query90	1920	207	217	207
query91	138	143	121	121
query92	74	59	53	53
query93	1105	935	588	588
query94	686	411	301	301
query95	367	282	275	275
query96	494	553	283	283
query97	2705	2751	2660	2660
query98	231	209	217	209
query99	1675	1380	1266	1266
Total cold run time: 272729 ms
Total hot run time: 181615 ms

doris-robot · 2025-07-02T15:58:02Z

ClickBench: Total hot run time: 29.25 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 69600e9067934e34d5c64659f0122d50fece4ab1, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.25	0.08	0.08
query4	1.60	0.11	0.11
query5	0.44	0.44	0.41
query6	1.21	0.66	0.64
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.50	0.52
query10	0.56	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.63	0.62	0.62
query14	0.80	0.82	0.84
query15	0.89	0.88	0.87
query16	0.39	0.39	0.41
query17	1.08	1.07	1.05
query18	0.23	0.23	0.21
query19	1.97	1.85	1.80
query20	0.01	0.01	0.02
query21	15.40	0.92	0.54
query22	0.75	1.17	0.66
query23	14.99	1.37	0.66
query24	8.32	1.35	0.58
query25	0.48	0.13	0.15
query26	0.64	0.16	0.14
query27	0.06	0.06	0.05
query28	9.61	0.81	0.42
query29	12.55	4.00	3.30
query30	0.24	0.09	0.06
query31	2.86	0.59	0.38
query32	3.23	0.55	0.48
query33	3.12	3.05	3.13
query34	15.95	5.38	4.77
query35	4.82	4.78	4.86
query36	0.70	0.51	0.49
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.14	0.14
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.39 s
Total hot run time: 29.25 s

doris-robot · 2025-07-02T17:05:25Z

BE UT Coverage Report

Increment line coverage 70.83% (17/24) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.24% (15420/26940)
Line Coverage	46.28% (139977/302468)
Region Coverage	45.59% (70953/155621)
Branch Coverage	40.33% (37439/92826)

eldenmoon · 2025-07-04T03:02:13Z

run buildall

be/test/vec/jsonb/json_parser_test.cpp

doris-robot · 2025-07-04T03:37:02Z

TPC-H: Total hot run time: 33601 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3d3f339d11f4b00a478fd7b3f418680f564c1ec7, data reload: false

------ Round 1 ----------------------------------
q1	17587	5154	5087	5087
q2	1916	279	177	177
q3	10333	1304	717	717
q4	10249	987	500	500
q5	8110	2399	2317	2317
q6	180	169	128	128
q7	896	726	609	609
q8	9305	1179	1020	1020
q9	6931	5089	5092	5089
q10	6885	2381	1946	1946
q11	454	281	269	269
q12	348	352	215	215
q13	17759	3681	3067	3067
q14	227	225	225	225
q15	566	475	472	472
q16	419	410	373	373
q17	583	869	353	353
q18	7490	7015	7116	7015
q19	1583	948	538	538
q20	312	338	217	217
q21	3654	3206	2294	2294
q22	1068	997	973	973
Total cold run time: 106855 ms
Total hot run time: 33601 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5167	5120	5143	5120
q2	234	323	219	219
q3	2195	2653	2251	2251
q4	1336	1767	1351	1351
q5	4182	4575	4530	4530
q6	222	169	131	131
q7	2110	1965	1843	1843
q8	2592	2493	2596	2493
q9	7372	7207	7344	7207
q10	3090	3611	2874	2874
q11	571	497	497	497
q12	698	818	625	625
q13	3831	4159	3405	3405
q14	277	299	284	284
q15	519	480	569	480
q16	460	480	436	436
q17	1142	1612	1387	1387
q18	8051	7641	7618	7618
q19	821	752	798	752
q20	1987	1962	1809	1809
q21	4750	4519	4310	4310
q22	1075	1052	1014	1014
Total cold run time: 52682 ms
Total hot run time: 50636 ms

doris-robot · 2025-07-04T03:48:33Z

TPC-DS: Total hot run time: 184874 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3d3f339d11f4b00a478fd7b3f418680f564c1ec7, data reload: false

query1	996	390	380	380
query2	6554	1668	1688	1668
query3	6744	213	212	212
query4	25889	23660	23423	23423
query5	4332	575	419	419
query6	315	212	200	200
query7	4637	496	289	289
query8	259	216	212	212
query9	8624	2623	2634	2623
query10	474	332	283	283
query11	15658	15094	14928	14928
query12	160	106	105	105
query13	1662	523	402	402
query14	9320	5796	5850	5796
query15	200	181	173	173
query16	7711	642	489	489
query17	1264	736	591	591
query18	2022	411	295	295
query19	195	194	165	165
query20	117	119	115	115
query21	213	127	107	107
query22	4121	4328	4100	4100
query23	34027	32984	33026	32984
query24	8420	2367	2350	2350
query25	519	453	378	378
query26	1124	266	147	147
query27	2708	512	352	352
query28	4273	2132	2113	2113
query29	719	552	443	443
query30	284	212	190	190
query31	920	827	767	767
query32	68	65	57	57
query33	543	355	313	313
query34	790	838	512	512
query35	767	803	734	734
query36	953	964	877	877
query37	112	97	75	75
query38	4195	4071	4013	4013
query39	1492	1434	1424	1424
query40	210	113	104	104
query41	55	56	51	51
query42	127	120	110	110
query43	496	503	482	482
query44	1357	846	821	821
query45	175	168	171	168
query46	840	1014	610	610
query47	1792	1781	1709	1709
query48	387	413	312	312
query49	737	482	380	380
query50	621	676	415	415
query51	4194	4151	4105	4105
query52	113	109	98	98
query53	225	257	182	182
query54	564	552	491	491
query55	81	81	85	81
query56	301	292	275	275
query57	1166	1178	1103	1103
query58	264	266	254	254
query59	2560	2700	2588	2588
query60	313	316	294	294
query61	124	115	118	115
query62	804	716	655	655
query63	223	187	189	187
query64	4282	997	655	655
query65	4289	4138	4248	4138
query66	1060	401	309	309
query67	15660	15727	15561	15561
query68	8382	897	532	532
query69	459	294	265	265
query70	1146	1125	1132	1125
query71	465	342	301	301
query72	5521	4714	4678	4678
query73	718	594	353	353
query74	8895	9215	8605	8605
query75	3797	3174	2707	2707
query76	3620	1131	706	706
query77	781	386	285	285
query78	10010	10219	9235	9235
query79	1925	817	593	593
query80	583	517	440	440
query81	464	260	288	260
query82	420	126	91	91
query83	244	253	231	231
query84	241	102	77	77
query85	762	341	377	341
query86	326	273	291	273
query87	4551	4387	4328	4328
query88	3232	2241	2263	2241
query89	379	316	278	278
query90	1921	208	209	208
query91	137	133	106	106
query92	78	60	56	56
query93	1076	941	581	581
query94	669	407	310	310
query95	370	299	291	291
query96	486	555	275	275
query97	2748	2744	2683	2683
query98	236	217	200	200
query99	1416	1384	1262	1262
Total cold run time: 272459 ms
Total hot run time: 184874 ms

doris-robot · 2025-07-04T03:53:50Z

ClickBench: Total hot run time: 29.53 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3d3f339d11f4b00a478fd7b3f418680f564c1ec7, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.25	0.08	0.08
query4	1.61	0.10	0.11
query5	0.45	0.44	0.41
query6	1.16	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.62	0.51	0.52
query10	0.57	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.60	0.60
query14	0.80	0.82	0.81
query15	0.91	0.88	0.88
query16	0.38	0.38	0.38
query17	1.04	1.09	1.06
query18	0.22	0.21	0.22
query19	1.99	1.86	1.83
query20	0.02	0.01	0.01
query21	15.39	0.88	0.55
query22	0.76	1.19	0.60
query23	14.99	1.40	0.63
query24	6.91	1.42	0.80
query25	0.50	0.30	0.06
query26	0.64	0.16	0.15
query27	0.06	0.05	0.06
query28	9.59	0.94	0.46
query29	12.54	3.94	3.27
query30	0.26	0.09	0.07
query31	2.85	0.63	0.38
query32	3.26	0.56	0.47
query33	3.10	3.15	3.05
query34	16.21	5.55	4.84
query35	4.87	4.89	4.90
query36	0.67	0.50	0.48
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.15	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.21 s
Total hot run time: 29.53 s

doris-robot · 2025-07-04T04:54:00Z

BE UT Coverage Report

Increment line coverage 89.19% (33/37) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.43% (15475/26946)
Line Coverage	46.37% (140251/302446)
Region Coverage	45.69% (71102/155607)
Branch Coverage	40.41% (37490/92784)

amorynan · 2025-07-07T14:29:52Z

run buildall

doris-robot · 2025-07-07T15:08:25Z

TPC-H: Total hot run time: 33291 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cc5efb1f3ef0ddffbea553a2bfc5b8d4ee84eb3, data reload: false

------ Round 1 ----------------------------------
q1	17595	5208	5019	5019
q2	1934	279	179	179
q3	10355	1278	713	713
q4	10243	1043	533	533
q5	8087	2375	2331	2331
q6	176	158	127	127
q7	880	748	599	599
q8	9302	1239	1085	1085
q9	6767	5114	5089	5089
q10	6876	2358	1964	1964
q11	487	288	279	279
q12	344	350	213	213
q13	17756	3677	3134	3134
q14	234	230	212	212
q15	561	499	477	477
q16	411	423	377	377
q17	591	855	366	366
q18	7507	7285	7206	7206
q19	1396	953	547	547
q20	320	349	224	224
q21	3777	3191	2326	2326
q22	360	315	291	291
Total cold run time: 105959 ms
Total hot run time: 33291 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5098	5083	5137	5083
q2	239	321	221	221
q3	2104	2671	2267	2267
q4	1390	1783	1383	1383
q5	4191	4301	4486	4301
q6	214	166	125	125
q7	2069	1993	1765	1765
q8	2641	2640	2596	2596
q9	7302	7303	7109	7109
q10	3111	3368	2839	2839
q11	592	526	495	495
q12	701	775	675	675
q13	3558	3908	3350	3350
q14	298	307	290	290
q15	525	489	530	489
q16	482	494	450	450
q17	1181	1613	1399	1399
q18	7876	7604	7637	7604
q19	804	775	852	775
q20	1956	1989	1869	1869
q21	4756	4305	4363	4305
q22	645	582	545	545
Total cold run time: 51733 ms
Total hot run time: 49935 ms

doris-robot · 2025-07-07T15:19:59Z

TPC-DS: Total hot run time: 185430 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cc5efb1f3ef0ddffbea553a2bfc5b8d4ee84eb3, data reload: false

query1	1002	391	399	391
query2	6524	1643	1624	1624
query3	6737	208	206	206
query4	26021	23725	23094	23094
query5	4366	591	432	432
query6	311	212	207	207
query7	4626	509	292	292
query8	279	214	211	211
query9	8597	2592	2616	2592
query10	466	342	286	286
query11	15177	15076	14884	14884
query12	149	107	107	107
query13	1650	541	421	421
query14	8579	5854	5890	5854
query15	203	190	182	182
query16	7781	442	268	268
query17	1314	732	605	605
query18	2029	410	312	312
query19	197	192	159	159
query20	128	120	115	115
query21	213	124	106	106
query22	4145	4275	4069	4069
query23	33901	33018	33016	33016
query24	8466	2404	2354	2354
query25	525	492	414	414
query26	1228	268	148	148
query27	2749	518	339	339
query28	4299	2100	2091	2091
query29	715	568	451	451
query30	284	217	202	202
query31	899	816	766	766
query32	68	63	60	60
query33	554	332	267	267
query34	788	841	517	517
query35	616	636	562	562
query36	968	979	894	894
query37	117	103	73	73
query38	4131	4114	4226	4114
query39	1458	1443	1439	1439
query40	204	117	105	105
query41	58	59	51	51
query42	123	107	106	106
query43	499	500	482	482
query44	1304	816	813	813
query45	171	171	164	164
query46	830	1012	621	621
query47	1750	1795	1733	1733
query48	390	431	305	305
query49	722	483	394	394
query50	641	737	411	411
query51	4169	4253	4133	4133
query52	105	103	102	102
query53	230	255	185	185
query54	571	561	501	501
query55	80	78	81	78
query56	308	304	272	272
query57	1181	1203	1118	1118
query58	260	254	257	254
query59	2519	2635	2572	2572
query60	317	313	298	298
query61	125	118	117	117
query62	804	731	660	660
query63	227	185	183	183
query64	4328	1213	808	808
query65	4266	4174	4249	4174
query66	1083	415	306	306
query67	15756	15640	15379	15379
query68	8397	912	535	535
query69	497	310	275	275
query70	1173	1095	1067	1067
query71	454	323	297	297
query72	5588	4708	4601	4601
query73	701	561	346	346
query74	8861	9117	8837	8837
query75	3770	3176	2591	2591
query76	3638	1149	728	728
query77	791	384	287	287
query78	10989	10952	10312	10312
query79	1930	841	572	572
query80	611	512	428	428
query81	461	251	224	224
query82	439	127	92	92
query83	260	253	246	246
query84	246	108	90	90
query85	793	427	318	318
query86	328	315	305	305
query87	4439	4471	4416	4416
query88	3502	2245	2269	2245
query89	392	306	282	282
query90	1925	209	207	207
query91	138	141	111	111
query92	73	59	58	58
query93	1452	978	598	598
query94	695	341	197	197
query95	386	286	283	283
query96	505	568	278	278
query97	2717	2754	2635	2635
query98	233	214	193	193
query99	1433	1419	1327	1327
Total cold run time: 273098 ms
Total hot run time: 185430 ms

doris-robot · 2025-07-07T15:25:15Z

ClickBench: Total hot run time: 29.88 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cc5efb1f3ef0ddffbea553a2bfc5b8d4ee84eb3, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.25	0.08	0.08
query4	1.62	0.10	0.11
query5	0.43	0.41	0.42
query6	1.18	0.66	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.59	0.51	0.52
query10	0.56	0.56	0.56
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.60	0.62
query14	0.80	0.81	0.81
query15	0.91	0.87	0.87
query16	0.39	0.40	0.40
query17	1.04	1.09	1.10
query18	0.22	0.21	0.22
query19	1.90	1.85	1.90
query20	0.02	0.01	0.02
query21	15.39	0.89	0.53
query22	0.74	1.16	0.63
query23	15.07	1.35	0.65
query24	7.64	1.01	0.99
query25	0.50	0.14	0.12
query26	0.63	0.16	0.13
query27	0.06	0.06	0.06
query28	9.23	0.90	0.44
query29	12.54	3.96	3.34
query30	0.25	0.09	0.07
query31	2.86	0.60	0.39
query32	3.25	0.56	0.48
query33	3.09	3.14	3.10
query34	16.27	5.42	4.78
query35	4.83	4.82	4.82
query36	0.74	0.51	0.51
query37	0.09	0.07	0.06
query38	0.05	0.05	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.62 s
Total hot run time: 29.88 s

doris-robot · 2025-07-07T16:23:34Z

BE UT Coverage Report

Increment line coverage 47.06% (32/68) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.61% (15578/27039)
Line Coverage	46.50% (141485/304296)
Region Coverage	45.76% (71560/156372)
Branch Coverage	40.45% (37702/93214)

be/src/vec/columns/column_variant.cpp

eldenmoon · 2025-07-08T02:30:06Z

regression-test/data/variant_p0/nested2.out

+2	{"nested":[{"a":1,"c":1.1}]}
+
+-- !sql_1 --
+["1", ""1""]


这个""1"" 看着不是一个合法的json输出

amorynan · 2025-07-08T02:43:21Z

regression-test/suites/variant_p0/nested2.groovy

+            // test cast to array<double> 
+            qt_sql_14 """select cast(v['nested']['a'] as array<double>), size(cast(v['nested']['a'] as array<double>)) from ${table_name} order by k"""
+            qt_sql_15 """select cast(v['nested']['b'] as array<double>), size(cast(v['nested']['b'] as array<double>)) from ${table_name} order by k"""
+            qt_sql_16 """select cast(v['nested']['c'] as array<double>), size(cast(v['nested']['c'] as array<double>)) from ${table_name} order by k"""


in sql_select_batch

doris-robot · 2025-07-10T06:27:24Z

BE UT Coverage Report

Increment line coverage 59.70% (40/67) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.33% (15588/27190)
Line Coverage	46.07% (138934/301584)
Region Coverage	35.44% (103782/292848)
Branch Coverage	37.95% (45728/120487)

amorynan · 2025-07-10T06:49:17Z

run buildall

doris-robot · 2025-07-10T08:22:46Z

TPC-H: Total hot run time: 33338 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 98a06331317b9b72610452c3134388fb8a98455b, data reload: false

------ Round 1 ----------------------------------
q1	17556	5188	5014	5014
q2	1926	299	219	219
q3	10263	1287	707	707
q4	10229	994	533	533
q5	7713	2354	2374	2354
q6	178	157	127	127
q7	915	745	595	595
q8	9298	1295	1060	1060
q9	6840	5087	5064	5064
q10	6880	2364	1958	1958
q11	479	298	276	276
q12	339	343	210	210
q13	17784	3706	3105	3105
q14	232	225	214	214
q15	559	480	475	475
q16	424	431	367	367
q17	599	874	349	349
q18	7582	7260	7281	7260
q19	1850	965	560	560
q20	322	332	220	220
q21	3731	3249	2375	2375
q22	378	318	296	296
Total cold run time: 106077 ms
Total hot run time: 33338 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5200	5062	5021	5021
q2	246	325	218	218
q3	2156	2679	2305	2305
q4	1362	1785	1351	1351
q5	4252	4288	4563	4288
q6	223	184	137	137
q7	2030	2021	1774	1774
q8	2648	2682	2653	2653
q9	7350	7287	7258	7258
q10	3178	3305	2855	2855
q11	614	521	498	498
q12	745	887	633	633
q13	3498	3924	3375	3375
q14	289	301	272	272
q15	512	473	489	473
q16	460	489	448	448
q17	1223	1593	1487	1487
q18	8048	7765	7709	7709
q19	806	820	807	807
q20	2027	1967	1814	1814
q21	4762	4387	4300	4300
q22	622	600	543	543
Total cold run time: 52251 ms
Total hot run time: 50219 ms

doris-robot · 2025-07-10T08:34:20Z

TPC-DS: Total hot run time: 185550 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 98a06331317b9b72610452c3134388fb8a98455b, data reload: false

query1	1002	373	408	373
query2	6510	1696	1678	1678
query3	6742	207	217	207
query4	26048	23281	23511	23281
query5	4339	574	431	431
query6	315	210	202	202
query7	4631	493	299	299
query8	279	220	214	214
query9	8620	2659	2654	2654
query10	476	326	275	275
query11	15584	14991	14891	14891
query12	156	106	105	105
query13	1652	527	414	414
query14	8493	5727	5659	5659
query15	203	193	186	186
query16	7291	612	500	500
query17	1215	726	592	592
query18	2009	405	319	319
query19	192	193	164	164
query20	126	175	123	123
query21	212	118	109	109
query22	4355	4262	3962	3962
query23	33687	33187	33184	33184
query24	8492	2389	2398	2389
query25	552	465	394	394
query26	1246	263	157	157
query27	2746	508	355	355
query28	4315	2137	2115	2115
query29	760	544	431	431
query30	283	218	190	190
query31	901	839	751	751
query32	69	69	61	61
query33	561	374	329	329
query34	786	844	540	540
query35	796	809	721	721
query36	947	993	886	886
query37	116	95	75	75
query38	4078	4124	4070	4070
query39	1485	1444	1412	1412
query40	212	115	105	105
query41	54	54	51	51
query42	121	109	104	104
query43	502	496	472	472
query44	1320	823	850	823
query45	169	167	159	159
query46	831	1019	630	630
query47	1745	1829	1692	1692
query48	385	410	315	315
query49	741	491	399	399
query50	611	679	409	409
query51	4171	4214	4110	4110
query52	108	108	95	95
query53	224	251	187	187
query54	571	570	504	504
query55	81	80	90	80
query56	313	307	290	290
query57	1174	1181	1142	1142
query58	259	257	260	257
query59	2532	2683	2692	2683
query60	345	329	305	305
query61	129	123	124	123
query62	817	721	657	657
query63	226	228	191	191
query64	4295	1003	664	664
query65	4316	4178	4217	4178
query66	1123	405	316	316
query67	15907	15694	15219	15219
query68	7900	893	525	525
query69	475	305	262	262
query70	1149	1138	1071	1071
query71	468	325	306	306
query72	5754	4825	4771	4771
query73	660	641	353	353
query74	9208	9110	9027	9027
query75	3927	3199	2640	2640
query76	3586	1140	706	706
query77	775	374	294	294
query78	9927	10105	9553	9553
query79	2563	810	591	591
query80	639	528	451	451
query81	484	254	223	223
query82	451	128	93	93
query83	250	252	248	248
query84	243	106	84	84
query85	781	346	380	346
query86	386	302	293	293
query87	4457	4412	4307	4307
query88	3669	2313	2298	2298
query89	382	334	281	281
query90	1847	213	213	213
query91	140	147	112	112
query92	73	66	56	56
query93	2148	936	584	584
query94	674	390	301	301
query95	375	295	284	284
query96	499	624	284	284
query97	2696	2725	2664	2664
query98	241	202	200	200
query99	1389	1380	1271	1271
Total cold run time: 273768 ms
Total hot run time: 185550 ms

doris-robot · 2025-07-10T08:39:37Z

ClickBench: Total hot run time: 29.78 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 98a06331317b9b72610452c3134388fb8a98455b, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.24	0.07	0.08
query4	1.62	0.11	0.11
query5	0.44	0.42	0.43
query6	1.17	0.66	0.65
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.52	0.52
query10	0.57	0.56	0.59
query11	0.15	0.10	0.10
query12	0.14	0.12	0.11
query13	0.61	0.62	0.62
query14	0.78	0.82	0.80
query15	0.90	0.88	0.86
query16	0.39	0.39	0.39
query17	1.09	1.06	1.00
query18	0.23	0.21	0.21
query19	1.93	1.87	1.84
query20	0.01	0.01	0.02
query21	15.38	0.88	0.53
query22	0.75	1.27	0.62
query23	15.02	1.39	0.64
query24	6.66	1.90	1.07
query25	0.43	0.26	0.27
query26	0.60	0.16	0.13
query27	0.06	0.06	0.05
query28	9.76	0.91	0.43
query29	12.53	3.90	3.25
query30	0.25	0.09	0.07
query31	2.85	0.59	0.38
query32	3.23	0.55	0.47
query33	3.06	3.08	3.07
query34	16.07	5.30	4.80
query35	4.83	4.84	4.81
query36	0.68	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.15	0.14
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.72 s
Total hot run time: 29.78 s

doris-robot · 2025-07-10T09:53:33Z

BE UT Coverage Report

Increment line coverage 59.70% (40/67) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	57.34% (15588/27183)
Line Coverage	46.07% (138967/301627)
Region Coverage	35.42% (103851/293219)
Branch Coverage	37.91% (45747/120662)

eldenmoon

LGTM

github-actions · 2025-07-11T04:24:19Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-07-11T04:24:21Z

PR approved by anyone and no changes requested.

csun5285

lgtm

1. fix variant type conflicts with scalar and array 2. fix multi-level array can be parse into variant which should be report as error 3. fix convert_field_to_type convert_numric_type do not use PrimitiveType 4. add UT for function_cast :: FromVariant

…52696) (#53123) cherry-pick: #52696 and #53418

…52696 (#53119) picked from #52696

fix variant type conflicts

69600e9

eldenmoon reviewed Jul 2, 2025

View reviewed changes

be/src/vec/columns/column_variant.cpp Show resolved Hide resolved

eldenmoon reviewed Jul 2, 2025

View reviewed changes

be/src/vec/functions/function_cast.h Outdated Show resolved Hide resolved

eldenmoon reviewed Jul 2, 2025

View reviewed changes

be/src/vec/json/json_parser.cpp Outdated Show resolved Hide resolved

eldenmoon added dev/3.0.x dev/3.1.x p0_b labels Jul 2, 2025

add regression test and ut

3d3f339

eldenmoon changed the title ~~[fix](variant)fix variant type conflicts~~ [fix](variant)fix variant type conflicts in nested types Jul 4, 2025

eldenmoon reviewed Jul 4, 2025

View reviewed changes

be/test/vec/jsonb/json_parser_test.cpp Show resolved Hide resolved

fix some bugs

9cc5efb

eldenmoon reviewed Jul 8, 2025

View reviewed changes

be/src/vec/columns/column_variant.cpp Outdated Show resolved Hide resolved

eldenmoon reviewed Jul 8, 2025

View reviewed changes

amorynan commented Jul 8, 2025

View reviewed changes

fix nested2

98a0633

eldenmoon approved these changes Jul 11, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2025

github-actions bot added the reviewed label Jul 11, 2025

csun5285 approved these changes Jul 11, 2025

View reviewed changes

eldenmoon merged commit 179627f into apache:master Jul 11, 2025
24 of 27 checks passed

github-actions bot added dev/3.0.x-conflict dev/3.1.x-conflict labels Jul 11, 2025

amorynan mentioned this pull request Jul 11, 2025

branch-3.1: [fix](variant)fix variant type conflicts in nested types #52696 #53119

Merged

amorynan mentioned this pull request Jul 11, 2025

branch-3.0: [fix](variant)fix variant type conflicts in nested types (#52696) #53123

Merged

dataroaring pushed a commit that referenced this pull request Jul 18, 2025

branch-3.0: [fix](variant)fix variant type conflicts in nested types (#…

c451863

…52696) (#53123) cherry-pick: #52696 and #53418

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jul 18, 2025

morrySnow pushed a commit that referenced this pull request Jul 25, 2025

branch-3.1: [fix](variant)fix variant type conflicts in nested types #…

e4131f9

…52696 (#53119) picked from #52696

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jul 25, 2025

gavinchou mentioned this pull request Aug 15, 2025

Release Note 3.0.7 #54868

Open

[fix](variant)fix variant type conflicts in nested types #52696

[fix](variant)fix variant type conflicts in nested types #52696

Uh oh!

Conversation

amorynan commented Jul 2, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jul 2, 2025

Uh oh!

Uh oh!

eldenmoon commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

doris-robot commented Jul 2, 2025

Uh oh!

doris-robot commented Jul 2, 2025

Uh oh!

doris-robot commented Jul 2, 2025

Uh oh!

doris-robot commented Jul 2, 2025

BE UT Coverage Report

Uh oh!

eldenmoon commented Jul 4, 2025

Uh oh!

Uh oh!

doris-robot commented Jul 4, 2025

Uh oh!

doris-robot commented Jul 4, 2025

Uh oh!

doris-robot commented Jul 4, 2025

Uh oh!

doris-robot commented Jul 4, 2025

BE UT Coverage Report

Uh oh!

amorynan commented Jul 7, 2025

Uh oh!

doris-robot commented Jul 7, 2025

Uh oh!

doris-robot commented Jul 7, 2025

Uh oh!

doris-robot commented Jul 7, 2025

Uh oh!

doris-robot commented Jul 7, 2025

BE UT Coverage Report

Uh oh!

Uh oh!

eldenmoon Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

amorynan Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Jul 10, 2025

BE UT Coverage Report

Uh oh!

amorynan commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

Uh oh!

doris-robot commented Jul 10, 2025

BE UT Coverage Report

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

csun5285 left a comment

Choose a reason for hiding this comment

Uh oh!