Skip to content

Conversation

@amorynan
Copy link
Contributor

What problem does this PR solve?

)fix variant subcolumn without finalize in get behavior
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jul 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34022 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cef9b3b0319944a554ffddfc0fb04564866b137, data reload: false

------ Round 1 ----------------------------------
q1	17614	5193	5178	5178
q2	1927	277	177	177
q3	10664	1318	710	710
q4	10322	1008	543	543
q5	8425	2357	2326	2326
q6	183	161	128	128
q7	880	743	605	605
q8	9306	1300	1106	1106
q9	7515	5022	5326	5022
q10	6888	2360	1959	1959
q11	490	289	259	259
q12	337	352	210	210
q13	17760	3719	3125	3125
q14	228	230	220	220
q15	529	474	485	474
q16	421	441	373	373
q17	581	867	353	353
q18	7522	7167	7268	7167
q19	1241	946	565	565
q20	350	339	222	222
q21	3883	2587	2335	2335
q22	1050	965	979	965
Total cold run time: 108116 ms
Total hot run time: 34022 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5150	5147	5129	5129
q2	244	326	222	222
q3	2186	2711	2343	2343
q4	1385	1784	1290	1290
q5	4353	4578	4651	4578
q6	228	167	128	128
q7	2031	2029	1878	1878
q8	2665	2721	2599	2599
q9	7350	7344	7216	7216
q10	3103	3285	2831	2831
q11	591	527	488	488
q12	860	864	637	637
q13	3533	3822	3452	3452
q14	282	312	279	279
q15	528	504	470	470
q16	455	490	465	465
q17	1210	1569	1367	1367
q18	8000	7828	7592	7592
q19	813	865	898	865
q20	2044	2128	1910	1910
q21	5049	4699	4540	4540
q22	1123	1115	1048	1048
Total cold run time: 53183 ms
Total hot run time: 51327 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187397 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cef9b3b0319944a554ffddfc0fb04564866b137, data reload: false

query1	1010	387	400	387
query2	6513	1711	1692	1692
query3	6759	210	212	210
query4	26862	23152	23507	23152
query5	4373	587	445	445
query6	297	226	192	192
query7	4619	483	290	290
query8	255	211	206	206
query9	8590	2626	2629	2626
query10	454	317	278	278
query11	15276	15058	14832	14832
query12	159	108	109	108
query13	1661	537	395	395
query14	8699	5969	5885	5885
query15	213	195	176	176
query16	7135	635	495	495
query17	952	716	591	591
query18	1980	407	317	317
query19	200	190	174	174
query20	124	116	114	114
query21	217	122	103	103
query22	4173	4193	4669	4193
query23	35082	33928	33775	33775
query24	8473	2289	2368	2289
query25	528	490	377	377
query26	1232	261	143	143
query27	2787	530	335	335
query28	4289	2131	2097	2097
query29	775	561	422	422
query30	280	223	182	182
query31	914	836	764	764
query32	77	59	63	59
query33	540	363	321	321
query34	784	846	533	533
query35	776	823	733	733
query36	986	1023	896	896
query37	104	96	74	74
query38	4172	4130	4206	4130
query39	1483	1444	1445	1444
query40	206	113	104	104
query41	55	59	50	50
query42	114	99	98	98
query43	514	498	478	478
query44	1327	833	809	809
query45	182	169	165	165
query46	825	989	619	619
query47	1755	1863	1757	1757
query48	390	407	298	298
query49	732	498	385	385
query50	644	697	407	407
query51	5524	5461	5536	5461
query52	105	102	95	95
query53	219	260	178	178
query54	553	566	480	480
query55	76	81	80	80
query56	304	286	273	273
query57	1176	1223	1139	1139
query58	263	284	253	253
query59	2549	2673	2583	2583
query60	331	324	309	309
query61	126	122	123	122
query62	785	705	643	643
query63	220	187	185	185
query64	4381	982	643	643
query65	4275	4154	4196	4154
query66	1136	400	366	366
query67	15911	16011	15593	15593
query68	8545	891	508	508
query69	516	318	274	274
query70	1210	1155	1072	1072
query71	493	329	292	292
query72	5588	4807	4719	4719
query73	715	605	351	351
query74	9244	9258	8808	8808
query75	3937	3263	2686	2686
query76	3772	1171	704	704
query77	793	376	288	288
query78	9927	10135	9284	9284
query79	5907	801	554	554
query80	663	535	501	501
query81	464	250	219	219
query82	710	124	96	96
query83	282	257	232	232
query84	291	101	84	84
query85	788	360	315	315
query86	331	303	293	293
query87	4479	4498	4407	4407
query88	2945	2292	2273	2273
query89	456	343	286	286
query90	1931	211	208	208
query91	139	139	112	112
query92	77	59	59	59
query93	3187	931	562	562
query94	674	412	316	316
query95	377	296	294	294
query96	504	570	282	282
query97	2715	2752	2670	2670
query98	241	206	204	204
query99	1446	1397	1282	1282
Total cold run time: 281828 ms
Total hot run time: 187397 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cef9b3b0319944a554ffddfc0fb04564866b137, data reload: false

query1	0.04	0.05	0.04
query2	0.08	0.04	0.04
query3	0.25	0.07	0.08
query4	1.63	0.11	0.11
query5	0.45	0.43	0.40
query6	1.14	0.67	0.66
query7	0.03	0.02	0.01
query8	0.05	0.03	0.03
query9	0.58	0.52	0.52
query10	0.59	0.57	0.57
query11	0.16	0.11	0.11
query12	0.16	0.11	0.12
query13	0.63	0.61	0.60
query14	0.81	0.82	0.83
query15	0.90	0.88	0.88
query16	0.38	0.39	0.37
query17	1.07	1.12	1.07
query18	0.22	0.22	0.20
query19	1.94	1.91	1.79
query20	0.01	0.01	0.01
query21	15.42	0.92	0.55
query22	0.74	1.24	0.74
query23	14.83	1.38	0.66
query24	7.20	1.17	0.39
query25	0.49	0.13	0.10
query26	0.69	0.16	0.14
query27	0.06	0.05	0.06
query28	9.43	0.90	0.44
query29	12.57	4.02	3.32
query30	3.01	3.03	2.97
query31	2.82	0.56	0.39
query32	3.22	0.54	0.46
query33	3.15	3.11	3.11
query34	16.06	5.33	4.80
query35	4.82	4.77	4.84
query36	0.69	0.51	0.49
query37	0.09	0.07	0.07
query38	0.07	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.83 s
Total hot run time: 32.14 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (11/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.49% (15734/27366)
Line Coverage 46.17% (140406/304077)
Region Coverage 35.44% (104622/295248)
Branch Coverage 38.06% (46144/121239)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (11/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.20% (21796/26842)
Line Coverage 73.79% (223971/303519)
Region Coverage 61.49% (186277/302917)
Branch Coverage 65.33% (80087/122587)

eldenmoon
eldenmoon previously approved these changes Jul 17, 2025
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 17, 2025
@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33835 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60651601f22196a0bfed7a7c7ecf58e5c3160af0, data reload: false

------ Round 1 ----------------------------------
q1	17549	5227	5088	5088
q2	1922	286	180	180
q3	10347	1318	703	703
q4	10217	1005	579	579
q5	7649	2439	2277	2277
q6	182	161	130	130
q7	897	742	589	589
q8	9325	1278	1071	1071
q9	7589	5142	5059	5059
q10	6895	2380	1960	1960
q11	468	277	266	266
q12	342	354	212	212
q13	17772	3742	3068	3068
q14	227	220	215	215
q15	538	467	489	467
q16	419	439	365	365
q17	577	865	352	352
q18	7484	7101	7218	7101
q19	1216	970	579	579
q20	357	342	220	220
q21	3758	3215	2409	2409
q22	1039	976	945	945
Total cold run time: 106769 ms
Total hot run time: 33835 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5297	5127	5147	5127
q2	240	329	215	215
q3	2202	2621	2330	2330
q4	1352	1787	1335	1335
q5	4218	4604	4614	4604
q6	221	169	124	124
q7	1980	1910	1826	1826
q8	2699	2565	2624	2565
q9	7389	7279	7211	7211
q10	3131	3332	2861	2861
q11	583	518	501	501
q12	723	784	684	684
q13	3611	3963	3383	3383
q14	300	326	301	301
q15	529	491	488	488
q16	438	521	447	447
q17	1200	1730	1419	1419
q18	7810	7608	7663	7608
q19	822	835	1079	835
q20	2065	2018	1830	1830
q21	4795	4379	4306	4306
q22	1064	1006	982	982
Total cold run time: 52669 ms
Total hot run time: 50982 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187371 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60651601f22196a0bfed7a7c7ecf58e5c3160af0, data reload: false

query1	1000	384	406	384
query2	6534	1781	1694	1694
query3	6738	218	220	218
query4	27132	23319	23325	23319
query5	4368	584	431	431
query6	307	221	206	206
query7	4632	499	288	288
query8	266	221	220	220
query9	8631	2580	2558	2558
query10	458	345	266	266
query11	15309	15050	15254	15050
query12	153	108	106	106
query13	1643	509	378	378
query14	8917	5810	5770	5770
query15	199	184	172	172
query16	7212	600	485	485
query17	1168	689	560	560
query18	1966	391	304	304
query19	185	183	153	153
query20	117	112	117	112
query21	215	122	110	110
query22	4380	4340	4197	4197
query23	34125	32866	33198	32866
query24	8476	2368	2397	2368
query25	575	496	423	423
query26	1240	267	151	151
query27	2767	508	342	342
query28	4334	2129	2104	2104
query29	788	578	464	464
query30	291	225	190	190
query31	932	841	760	760
query32	72	66	65	65
query33	563	362	320	320
query34	797	840	513	513
query35	773	827	760	760
query36	946	1016	937	937
query37	111	105	76	76
query38	4152	4197	4074	4074
query39	1492	1440	1441	1440
query40	214	119	109	109
query41	65	61	60	60
query42	125	167	103	103
query43	517	520	474	474
query44	1332	821	819	819
query45	173	166	161	161
query46	828	1003	615	615
query47	1818	1855	1805	1805
query48	377	425	301	301
query49	717	454	375	375
query50	646	682	408	408
query51	5608	5592	5534	5534
query52	110	105	102	102
query53	231	249	175	175
query54	573	560	501	501
query55	80	78	80	78
query56	349	309	277	277
query57	1206	1215	1161	1161
query58	264	250	253	250
query59	2666	2652	2604	2604
query60	312	322	319	319
query61	132	119	126	119
query62	778	707	693	693
query63	220	191	185	185
query64	4316	1008	725	725
query65	4278	4197	4178	4178
query66	1125	404	310	310
query67	16058	15974	15588	15588
query68	8407	877	520	520
query69	474	307	276	276
query70	1212	1090	1111	1090
query71	464	334	310	310
query72	5555	4613	4548	4548
query73	704	554	345	345
query74	8841	9111	9087	9087
query75	3905	3182	2694	2694
query76	3668	1156	726	726
query77	785	376	283	283
query78	9973	10248	9374	9374
query79	2732	809	589	589
query80	618	491	449	449
query81	467	261	230	230
query82	449	127	97	97
query83	279	245	278	245
query84	294	98	83	83
query85	786	350	313	313
query86	341	324	286	286
query87	4505	4453	4433	4433
query88	3016	2301	2304	2301
query89	410	317	294	294
query90	1944	206	206	206
query91	134	140	106	106
query92	88	61	54	54
query93	1199	922	578	578
query94	696	410	307	307
query95	383	308	286	286
query96	490	568	283	283
query97	2718	2790	2643	2643
query98	239	213	216	213
query99	1424	1414	1259	1259
Total cold run time: 276282 ms
Total hot run time: 187371 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 60651601f22196a0bfed7a7c7ecf58e5c3160af0, data reload: false

query1	0.05	0.03	0.04
query2	0.08	0.04	0.04
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.45	0.41	0.42
query6	1.17	0.65	0.67
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.52	0.50
query10	0.58	0.57	0.58
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.62
query14	0.79	0.82	0.82
query15	0.90	0.87	0.89
query16	0.39	0.39	0.39
query17	1.11	1.02	1.07
query18	0.23	0.22	0.22
query19	1.94	1.89	1.79
query20	0.01	0.01	0.01
query21	15.42	0.92	0.56
query22	0.74	1.34	0.61
query23	14.84	1.38	0.67
query24	7.80	1.14	0.82
query25	0.42	0.14	0.08
query26	0.69	0.17	0.15
query27	0.06	0.06	0.06
query28	8.82	0.82	0.43
query29	12.55	3.90	3.31
query30	3.04	3.02	2.96
query31	2.82	0.58	0.38
query32	3.25	0.57	0.48
query33	3.12	3.23	3.09
query34	15.98	5.36	4.76
query35	4.79	4.85	4.76
query36	0.68	0.52	0.49
query37	0.09	0.08	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.14
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.66 s
Total hot run time: 32.31 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (12/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.43% (15775/27466)
Line Coverage 46.22% (142020/307238)
Region Coverage 35.70% (106848/299324)
Branch Coverage 38.21% (47174/123451)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (12/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.21% (21883/26945)
Line Coverage 73.78% (226324/306767)
Region Coverage 61.67% (189373/307054)
Branch Coverage 65.29% (81514/124841)

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 7272603 into apache:master Jul 18, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged not-merge/3.1 reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants