-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [fix](variant)fix variant type conflicts in nested types (#52696) #53123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch-3.0: [fix](variant)fix variant type conflicts in nested types (#52696) #53123
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
1. fix variant type conflicts with scalar and array 2. fix multi-level array can be parse into variant which should be report as error 3. fix convert_field_to_type convert_numric_type do not use PrimitiveType 4. add UT for function_cast :: FromVariant
3c9d5eb to
6d0cca1
Compare
|
run buildall |
TPC-H: Total hot run time: 39949 ms |
TPC-DS: Total hot run time: 195411 ms |
ClickBench: Total hot run time: 29.83 s |
|
run buildall |
TPC-H: Total hot run time: 39659 ms |
TPC-DS: Total hot run time: 196078 ms |
ClickBench: Total hot run time: 30.43 s |
|
run buildall |
TPC-H: Total hot run time: 39831 ms |
TPC-DS: Total hot run time: 196387 ms |
ClickBench: Total hot run time: 30.43 s |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 39939 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
ClickBench: Total hot run time: 30.88 s |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 39816 ms |
TPC-DS: Total hot run time: 198154 ms |
ClickBench: Total hot run time: 30.44 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40216 ms |
TPC-DS: Total hot run time: 196971 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
ClickBench: Total hot run time: 29.85 s |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry-pick: #52696 and #53418