branch-4.0: [feat](cloud) Cherry pick packed file prs #59693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
There was a problem hiding this comment.
Pull request overview
This PR cherry-picks packed file-related pull requests to branch-4.0, introducing a comprehensive packed file management system for cloud mode in Apache Doris. The changes add support for merging small files into larger "packed files" to optimize storage efficiency in cloud environments.
Key changes:
- New packed file metadata structures and storage in protobuf definitions
- Recycler logic to manage packed file lifecycle (correction, deletion, reference counting)
- Checker logic to validate packed file integrity
- Meta service RPC handler for updating packed file information
- Extensive test coverage for packed file operations
- Configuration parameters for tuning packed file behavior
Reviewed changes
Copilot reviewed 93 out of 93 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gensrc/proto/olap_file.proto | Added PackedSliceLocationPB message and packed_slice_locations map to rowset metadata |
| gensrc/proto/cloud.proto | Added PackedSlicePB, PackedFileInfoPB, PackedFileFooterPB messages and update_packed_file_info RPC |
| cloud/src/recycler/recycler.{h,cpp} | Core packed file recycling logic including ref count management and deletion |
| cloud/src/recycler/checker.{h,cpp} | Packed file integrity checker to detect leaks and inconsistencies |
| cloud/src/meta-service/meta_service.{h,cpp} | RPC handler for updating packed file metadata |
| cloud/src/meta-store/keys.{h,cpp} | Key encoding/decoding for packed file metadata storage |
| cloud/src/common/{config.h,bvars.{h,cpp}} | Configuration parameters and metrics for packed files |
| cloud/test/recycler_test.cpp | Comprehensive unit tests for packed file recycling |
| cloud/test/meta_service_test.cpp | Unit tests for update_packed_file_info RPC |
| regression-test/suites/load_p0/stream_load/test_packed_file_stream_load_case*.groovy | Integration tests for packed file with stream load |
| regression-test/suites/cloud_p0/packed_file/*.groovy | Integration tests for various packed file scenarios |
| be/test/* | Updated test files to use new index file writer API (begin_close/finish_close) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…erhead (apache#57770) Co-authored-by: Luwei <luwei@selectdb.com> Co-authored-by: Luwei <814383175@qq.com>
…files (apache#58839) Related PR: apache#57770 Problem Summary: The main change is to offload the entire delete bitmap calculation process—including file closing, rowset building, segment loading, and bitmap calculation—to a background thread pool. This prevents blocking the memtable flush thread, enhancing performance and concurrency.
…obustness (apache#58883) Debug & tooling: write/parse versioned PackedFileDebugInfoPB trailer, add packed_file_tool and unit tests for easier debugging Recycler retries: make packed file ref-count updates retryable/configurable to handle TXN_CONFLICTs Prevent leak on recycle timing: ensure rowsets with packed slices are processed even when the tablet is already marked recycled Trim logs: downgrade noisy state transition logs to VLOG_DEBUG while keeping upload completion details
…mall files (apache#59011) Related PR: apache#57770 Problem Summary: When merging small files with inverted indexes, the segment close operation was synchronously waiting for inverted index files to be uploaded to S3. This blocking behavior significantly impacted the memtable flush thread performance, causing bottlenecks in the data loading pipeline. Solution: The solution introduces a two-phase close mechanism for inverted index file writers: 1. **Asynchronous Close Phase**: During segment close, inverted index files are closed asynchronously and the S3 upload task is submitted immediately without waiting for completion. 2. **Wait Phase**: When the load channel closes, the system waits for all pending S3 upload tasks to complete, ensuring data consistency.
liaoxin01
force-pushed
the
cherry-pick-packed-file-prs
branch
from
ebeb626 to
4e33c27
Compare
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jan 12, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick: https://github.com/apache/doris/issues?q=state%3Aclosed%20label%3Apacked-file