HBASE-24849 Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2020 18:12
|
branch-1 also had issue with precommit QA. This is fixed now. Can u pls do a commit (new line or so) to trigger QA |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Aug 10, 2020
| public byte[][] rollWal(long now) throws IOException { | ||
| this.lastRollTime = now; | ||
| byte[][] regionsToFlush = wal.rollWriter(true); | ||
| this.rollRequest.set(false); |
There was a problem hiding this comment.
This is not as per other branch patches. Why?
There was a problem hiding this comment.
In order to be consistent with the previous
Comment on lines
+154
to
+160
| boolean periodic = false; | ||
| for (RollController controller : wals.values()) { | ||
| if (controller.needsPeriodicRoll(now)) { | ||
| periodic = true; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
This logic is not same as per branch-2 patches. What is different here? why?
There was a problem hiding this comment.
In order to be compatible with jdk1.7
| wal.registerWALActionsListener(new WALActionsListener.Base() { | ||
| @Override | ||
| public void logRollRequested(WALActionsListener.RollRequestReason reason) { | ||
| walNeedsRoll.put(wal, Boolean.TRUE); | ||
| RollController controller = wals.get(wal); |
There was a problem hiding this comment.
I see.. because of jdk 1.7 support, we have to use this way and that is what Findbugs complain.
WenFeiYi
changed the title
WenFeiYi
changed the title
Reidddddd
requested changes
Sep 29, 2020
|
One question, i don't get the solution, why this change can avoid all wals roll? |
|
There should be one key point in old version which leads to all WALs rolled, can you point that out. |
|
💔 -1 overall
This message was automatically generated. |
|
Please take a look at the |
|
I read @anoopsjohn's comment. If we can make sure the |
|
💔 -1 overall
This message was automatically generated. |
|
@Reidddddd In old version, it is not judged which wal triggered before roll, and all wals use the same roll period. |
|
Let's wait for QA |
|
can use this SuppressWarnings, with value and justification. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
We are cool now, thx for the contribution, this is nice @WenFeiYi |
Reidddddd
pushed a commit
to Reidddddd/hbase
that referenced
this pull request
Oct 17, 2020
…of ALL WALs when one of the WAL needs a roll (apache#2194) Signed-off-by: Reid Chan <reidchan@apache.org> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.