HBASE-24877 addendum: additional checks to avoid one extra possible race control in the initialize loop #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace control in the initialize loop
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Ping @Apache9 , new commit addressing comments from PR 2399, together with additional test ensuring we don't block the main thread if initialization keeps failing. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
approved these changes
Sep 22, 2020
Yeah, I believe it fixes it. Had done several runs and didn't get any failure. Also run latest UT failures, locally, but all passed for me, so I think those are unrelated. |
joshelser
reviewed
Sep 23, 2020
| (t,e) -> { | ||
| startupOngoing.set(true); | ||
| initThread = new Thread(this::initialize); | ||
| Threads.setDaemonThreadRunning(initThread, |
joshelser
approved these changes
Sep 23, 2020
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Latest failures seems unrelated. Merging it now. |
wchevreuil
added a commit
to wchevreuil/hbase
that referenced
this pull request
Sep 29, 2020
…ace control in the initialize loop (apache#2400) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
huaxiangsun
reviewed
Nov 5, 2020
| @@ -416,6 +416,17 @@ public synchronized UUID getPeerUUID() { | |||
|
|
|||
| } | |||
|
|
|||
| public static class FaultyReplicationEndpoint extends DoNothingReplicationEndpoint { | |||
There was a problem hiding this comment.
Bumping into this during rebase of HBASE-18070 branch. If count is not used, just remove it from this class?
There was a problem hiding this comment.
Yeah, I guess it's a left over from previous commits on this same PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.