-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25696 Need to initialize SLF4JBridgeHandler in jul-to-slf4j for… #3093
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Still trying locally, do not work yet... Let me dig more... |
… redirecting jul to slf4j
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
The UT could confirm that the approach works. But it still can not solve the problem for HBASE-22120. I guess the problem is that, the jul logger is initialized by java agent, which is initialized ahead of the main program, and even with a different class loader... Will dig more for HBASE-22120 but I think the patch is OK to solve the problems for the current master and other branches. Thanks. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it.
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failed UTs are because of the log4j2 appenders. It seems that log4j2 will always create the declared appenders even if it is not reference by any loggers. Will file another jira to see how to fix this. I guess there should be some flags for this, otherwise, I think we need to comment them out in the default log4j2.xml and let users uncomment them when they actually want to use them. Thanks. |
… redirecting jul to slf4j (apache#3093) Signed-off-by: Michael Stack <stack@apache.org>
… redirecting jul to slf4j (apache#3093) Signed-off-by: Michael Stack <stack@apache.org>
… redirecting jul to slf4j