Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage-node): support aws rds instance #342

Merged
merged 2 commits into from
May 6, 2023

Conversation

Xu-Wentao
Copy link
Collaborator

@Xu-Wentao Xu-Wentao commented May 6, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mlycore mlycore added the operator solutions of operator label May 6, 2023
@mlycore mlycore added this to the 0.3.0 milestone May 6, 2023
@Xu-Wentao Xu-Wentao changed the title feat(storage-node): merge commits feat(storage-node): support aws rds instance May 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #342 (6ee75c0) into main (3f4177c) will increase coverage by 0.71%.
The diff coverage is 48.09%.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   39.59%   40.30%   +0.71%     
==========================================
  Files          44       47       +3     
  Lines        4685     5019     +334     
==========================================
+ Hits         1855     2023     +168     
- Misses       2703     2858     +155     
- Partials      127      138      +11     
Impacted Files Coverage Δ
...perator/pkg/controllers/compute_node_controller.go 6.72% <ø> (ø)
...e-operator/pkg/reconcile/storagenode/aws/aurora.go 0.00% <0.00%> (ø)
...here-operator/pkg/reconcile/storagenode/aws/aws.go 0.00% <0.00%> (ø)
...rator/pkg/reconcile/storagenode/aws/rdsinstance.go 16.00% <16.00%> (ø)
...ator/cmd/shardingsphere-operator/manager/option.go 46.36% <19.23%> (-5.33%) ⬇️
...perator/pkg/controllers/storage_node_controller.go 68.01% <67.43%> (+68.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mlycore mlycore merged commit 4fec4e5 into apache:main May 6, 2023
@mlycore
Copy link
Contributor

mlycore commented Jul 11, 2023

#271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator solutions of operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants