Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to close some stale PRs and ones suggested to be closed by committer(s) or obviously inappropriate PRs (e.g. branch to branch).

Closes #15689
Closes #14640
Closes #15917
Closes #16188
Closes #16206

How was this patch tested?

N/A

@HyukjinKwon
Copy link
Member Author

cc @srowen Could you take a look and see if they are reasonable please?

@SparkQA
Copy link

SparkQA commented Dec 8, 2016

Test build #69847 has started for PR 16207 at commit c51011c.

@rxin
Copy link
Contributor

rxin commented Dec 8, 2016

Merging in master.

@rxin
Copy link
Contributor

rxin commented Dec 8, 2016

For some reason I couldn't merge this one. I pushed a commit directly to master. Can you close this one now?

@HyukjinKwon
Copy link
Member Author

Sure, thanks!

@HyukjinKwon HyukjinKwon closed this Dec 8, 2016
@HyukjinKwon
Copy link
Member Author

BTW, I believe we should add --allow-empty when it is merged.

@srowen
Copy link
Member

srowen commented Dec 8, 2016

Yes I have to edit the merge script to git commit --allow-empty ... but I don't know that we should always set it. It could prompt or something but I was too lazy to implement that.

Anyway that sounds fine and I have my own list of PRs to close that I'll 'flush' with a commit soon too.

@rxin
Copy link
Contributor

rxin commented Dec 8, 2016

Yea i'd say in general that --allow-empty shouldn't be there.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69847/
Test FAILed.

@HyukjinKwon HyukjinKwon deleted the closing-some-prs branch January 2, 2018 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants