Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 19, 2025

What changes were proposed in this PR?

This PR adds the following CI with new names:

  • core -> scala, currently contains all scala tests for multiple packages/services, we could do more separation and renaming later.
  • gui -> frontend, that is consistent to our repo directory rename.
  • python_udf -> python, to simplify and re-purpose, because it contains tests for entire python engine (although a main part is to support UDF).

Note that we will remove the old CIs in another PR.

Any related issues, documentation, discussions?

work related to #3939

How was this PR tested?

Manually tested with #3937.

Was this PR authored or co-authored using generative AI tooling?

No.

@Yicong-Huang Yicong-Huang self-assigned this Oct 19, 2025
Copilot AI review requested due to automatic review settings October 19, 2025 01:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames CI job names to better reflect their purpose and align with repository structure changes.

  • Renamed three CI job names for clarity: core to scala, gui to frontend, and python_udf to python
  • Updated GitHub workflow configuration to use the new job names
  • Updated branch protection rules to reference the renamed CI jobs

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/github-action-build.yml Updates CI job names from old to new naming convention
.asf.yaml Updates branch protection contexts to match renamed CI jobs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the ci changes related to CI label Oct 19, 2025
@Yicong-Huang Yicong-Huang changed the title chore(ci): update CI names chore(ci): add CI with new names Oct 19, 2025
@Yicong-Huang Yicong-Huang merged commit da67968 into main Oct 19, 2025
24 checks passed
@Yicong-Huang Yicong-Huang deleted the chore/ci/change-ci-names branch October 19, 2025 01:49
Yicong-Huang added a commit that referenced this pull request Oct 23, 2025
### What changes were proposed in this PR?
This PR cleans up the left over changes from CI updates:
1. it removes the old CI runs (caused by #3941). 
2. it removes the rules against `test-ci` branch (introduced by #3937
for testing purposes).


### Any related issues, documentation, discussions?
finishes and resolves #3939 

### How was this PR tested?
Manually tested.

### Was this PR authored or co-authored using generative AI tooling?
No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants