Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 18, 2025

What changes were proposed in this PR?

This PR is the initial setup for testing #3934. We create a new branch test-ci and add the branch protection rules against test-ci for testing purposes.

The rules names are exact string matches from Github Actions.

Any related issues, documentation, discussions?

related to #3934

How was this PR tested?

N/A. It should not affect any other branches. We are manually testing.

Was this PR authored or co-authored using generative AI tooling?

No.

Copilot AI review requested due to automatic review settings October 18, 2025 23:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up branch protection rules for a new test-ci branch to enable testing of CI configurations without affecting the main branch. The changes establish the same protection requirements as the main branch while allowing for safe experimentation.

  • Added branch protection configuration for test-ci branch
  • Configured required status checks including GUI, core, and Python UDF tests
  • Set up pull request review requirements with single approval needed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Yicong-Huang Yicong-Huang self-assigned this Oct 18, 2025
@Yicong-Huang Yicong-Huang added the ci changes related to CI label Oct 18, 2025
@github-actions github-actions bot removed the ci changes related to CI label Oct 18, 2025
@Yicong-Huang Yicong-Huang added ci changes related to CI backend Anything related to backend services and removed backend Anything related to backend services labels Oct 18, 2025
@github-actions github-actions bot removed the ci changes related to CI label Oct 19, 2025
@aglinxinyuan
Copy link
Contributor

LGTM!

@Yicong-Huang Yicong-Huang merged commit 870a9e0 into main Oct 19, 2025
11 checks passed
@Yicong-Huang Yicong-Huang deleted the chore/add-test-ci-branch-protection-rules branch October 19, 2025 00:22
Yicong-Huang added a commit that referenced this pull request Oct 19, 2025
### What changes were proposed in this PR?
This PR adds the following CI with new names:
- `core` -> `scala`, currently contains all scala tests for multiple
packages/services, we could do more separation and renaming later.
-  `gui` -> `frontend`, that is consistent to our repo directory rename.
- `python_udf` -> `python`, to simplify and re-purpose, because it
contains tests for entire python engine (although a main part is to
support UDF).

Note that we will remove the old CIs in another PR.

### Any related issues, documentation, discussions?
work related to #3939 

### How was this PR tested?
Manually tested with #3937.

### Was this PR authored or co-authored using generative AI tooling?
No.
Yicong-Huang added a commit that referenced this pull request Oct 23, 2025
### What changes were proposed in this PR?
This PR cleans up the left over changes from CI updates:
1. it removes the old CI runs (caused by #3941). 
2. it removes the rules against `test-ci` branch (introduced by #3937
for testing purposes).


### Any related issues, documentation, discussions?
finishes and resolves #3939 

### How was this PR tested?
Manually tested.

### Was this PR authored or co-authored using generative AI tooling?
No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants