Fix ip_allow optional methods specification #10246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
approved these changes
Aug 21, 2023
Member
SolidWallOfCode
left a comment
SolidWallOfCode
left a comment
There was a problem hiding this comment.
This is, IMHO, a bug in YAML-CPP, that this is fixed by using a new variable.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Make bad disk detection more robust (apache#10317) Update Proxy Verifier to v2.10.1 (apache#10322) Fix lua plugin build (apache#10319) cmake: Add support for building benchmarks (apache#10316) cmake: add tests for proxy/http3 (apache#10310) Cmake: Add tests in proxy/http proxy/http2 (apache#10305) add tests for src/records (apache#10302) cmake: add unit tests for proxy/logging (apache#10301) setup default install path, runtime user and group (apache#10299) cmake: add tests for proxy/hdrs (apache#10283) Fix ip_allow optional methods specification (apache#10246) Plugin promotions, deprecations and deletions (apache#10303) Use Dbg() for debug output in both core and plugins. (apache#9732) Remove in_addr forward declaration from experimental.h. (apache#10309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to doc, the
methodsfield is optional so the following should be a valid ip_allow config which allows all HTTP methods:However, ATS reports an error when parsing it.
The root cause is that yaml-cpp returns an invalid node for non-existent keys, which is fine, but it throws an exception when assigning the invalid node to another node. This PR prevents this and adds a test to exercise this case.