Use Dbg() for debug output in both core and plugins. #9732
Conversation
|
Doesn't yet have all the doc changes that would be necessary. |
include/tscore/DbgCtl.h
Outdated
|
|
||
| friend void TSDbgCtlDestroy(TSDbgCtl const *dbg_ctl); | ||
| }; | ||
| using DbgCtl = TSDbgCtl; |
There was a problem hiding this comment.
Maybe just absorb this header into DiagsTypes.h
|
After thinking about it some, I realize it would cause problems for Yahoo (and perhaps others) to change TSDbgCtl to a class. I'd prefer to add the namespace |
ywkaras
force-pushed
the
CppDbgCtl
branch
2 times, most recently
from
806ab86 to
5c8af80
Compare
Eliminate TSDbg(), TSIsDbgCtlSet(), TSDbgCtlCreate(), TSDbgCtlDestroy(). Eliminate TSDbgCtlUniqPtr type.
ywkaras
changed the title
|
This sets the stage for removing and replacing slow TSDebug() calls. |
|
I will make the doc changes for this in a follow on PR that also removes TSDebug(). |
| if (!m) { | ||
| return false; | ||
| } | ||
| if (!_ptr->second) { |
There was a problem hiding this comment.
Technically second should be std::atomic (or at least volatile), since it can be written from another thread. But doing that risks causing the generation of less performant code. And, it seems unlikely that any register buffering of the value would cause actual problems. std::atomic instances are not moveable, so they can' t be used in STL containers.
|
[approve ci] |
zwoop
left a comment
zwoop
left a comment
There was a problem hiding this comment.
Love it. We still have work to do in many plugins though, right?
Yes |
* asf/master: Make bad disk detection more robust (apache#10317) Update Proxy Verifier to v2.10.1 (apache#10322) Fix lua plugin build (apache#10319) cmake: Add support for building benchmarks (apache#10316) cmake: add tests for proxy/http3 (apache#10310) Cmake: Add tests in proxy/http proxy/http2 (apache#10305) add tests for src/records (apache#10302) cmake: add unit tests for proxy/logging (apache#10301) setup default install path, runtime user and group (apache#10299) cmake: add tests for proxy/hdrs (apache#10283) Fix ip_allow optional methods specification (apache#10246) Plugin promotions, deprecations and deletions (apache#10303) Use Dbg() for debug output in both core and plugins. (apache#9732) Remove in_addr forward declaration from experimental.h. (apache#10309)
2 participants
Eliminate TSDbg(), TSIsDbgCtlSet(), TSDbgCtlCreate(), TSDbgCtlDestroy().
Eliminate TSDbgCtlUniqPtr type.