Skip to content

Fix lua plugin build #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traeak merged 1 commit into from
Aug 31, 2023
Merged

Fix lua plugin build #10319

traeak merged 1 commit into from
Aug 31, 2023

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Aug 31, 2023

Fix #10318. We start using c++ compiler and the symbol log conflicts with math.h.

lua/ts_lua_log.cc:21:24: error: redefinition of 'log' as different kind of symbol
static TSTextLogObject log;
                       ^
/opt/brew/opt/llvm@16/bin/../include/c++/v1/math.h:827:1: note: previous definition is here
log(_A1 __x) _NOEXCEPT {return __builtin_log((double)__x);}
^

@masaori335 masaori335 added the Build work related to build configuration or environment label Aug 31, 2023
@masaori335 masaori335 added this to the 10.0.0 milestone Aug 31, 2023
@masaori335 masaori335 self-assigned this Aug 31, 2023
@traeak traeak merged commit 70e2127 into apache:master Aug 31, 2023
@shukitchan shukitchan mentioned this pull request Aug 31, 2023
Closed
@masaori335 masaori335 mentioned this pull request Aug 31, 2023
Merged
@jpeach
Copy link
Contributor

jpeach commented Sep 4, 2023

Relevant reading for <math.h> symbols in C++

https://developers.redhat.com/blog/2016/02/29/why-cstdlib-is-more-complicated-than-you-might-think
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89855

cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
cc69e2e 
* asf/master:
  Make bad disk detection more robust (apache#10317)
  Update Proxy Verifier to v2.10.1 (apache#10322)
  Fix lua plugin build (apache#10319)
  cmake: Add support for building benchmarks (apache#10316)
  cmake: add tests for proxy/http3 (apache#10310)
  Cmake: Add tests in proxy/http proxy/http2 (apache#10305)
  add tests for src/records (apache#10302)
  cmake: add unit tests for proxy/logging (apache#10301)
  setup default install path, runtime user and group (apache#10299)
  cmake: add tests for proxy/hdrs (apache#10283)
  Fix ip_allow optional methods specification (apache#10246)
  Plugin promotions, deprecations and deletions (apache#10303)
  Use Dbg() for debug output in both core and plugins. (apache#9732)
  Remove in_addr forward declaration from experimental.h. (apache#10309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shukitchan shukitchan shukitchan approved these changes

Assignees

@masaori335 masaori335

Labels

Build work related to build configuration or environment

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

Build error of lua plugin

4 participants

@masaori335 @jpeach @shukitchan @traeak