-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds OCSP support for BoringSSL #7298
Conversation
81db5f0
to
06d4602
Compare
Two comments for now. Maintenance - Having a snapshot of OpenSSL source code sounds a bit scary because it could bring security issues. I think we should have a very easy way to update the snapshot instantly. If there are modifications against the original code we should probably keep them as patch files as well. License - OpenSSL 3.0 and the code on their master branch are licensed under AL2. Although I didn't check whether the current license is compatible with AL2, AL2 version would be safer option in terms of licensing. The code on master may be unstable so I'm also ok with using non-AL2 version for now as long as the license is compatible. |
The APIs/underlying structures have changed enough to make this not a trivial thing to do. This is not the first openssl code to be added to the project. It looks like parts of BIO_fastopen.cc is copied from the project into our tree.
|
Personally, I'd like the library "ocsp4boring" to not be checked into the tree itself and rather that it was its own project that other projects could easily build against (like nginx). |
I agree that keeping ocsp4boring out of our source tree seems preferable. And rather user it as a separately installed package. |
Seems reasonable to move the ocsp4boring code out of tree. I'll follow up with a change to do this. |
Some of functions that this PR adds are going to be deprecated on OpenSSL 3.0. ATS uses three of those, and will need to use some replacements.
|
06d4602
to
7721db0
Compare
Randall is still working on this. |
fada783
to
cce9d49
Compare
30d3af9
to
148db52
Compare
82d8b42
to
39b5ef6
Compare
Requires the external library boringocsp
Requires the external library boringocsp (cherry picked from commit 5ddb462)
Cherry-picked to v9.1.x branch. |
* asf/9.1.x: (28 commits) Updated ChangeLog Make the rest of InkAPI allocators Proxy Allocated (apache#8106) Added missing milestones and updated slow log report script (apache#8168) Cleans up the code bit, including milliseconds consistency (apache#7989) Note YAML parser library bug, and work-around, in documentation. (apache#7963) Update INSTALL for URLs and version number (apache#8173) ESI plugin documentation updates. (apache#7970) Add a JSON schema for strategies.yaml (apache#7932) ensure hostname_offset is initialized to '0' to indicate null hostname (apache#8162) Fixed compile error with Linux AIO unit test (apache#7958) Enforce case for well known methods (apache#7886) Treat TRACE with body as bad request (apache#7905) Close connection after every bad request for HTTP/1.1 (apache#7885) use sendmsg and recvmsg (apache#7793) Apply log throttling to HTTP/2 session error rate messages (apache#7772) limit m_current_range to max value in RangeTransform (apache#4843) Fix HPACK eviction iterator manipulation (apache#8004) Replace fix assert in error event processing (apache#8058) Adds OCSP support for BoringSSL (apache#7298) .gitignore rules for gcov generated files (apache#8099) ...
No description provided.