Fix HPACK eviction iterator manipulation #8004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[approve ci freebsd] |
duke8253
approved these changes
Jun 28, 2021
|
@masaori335 will take a look |
masaori335
approved these changes
Jul 1, 2021
zwoop
pushed a commit
that referenced
this pull request
Jul 20, 2021
(cherry picked from commit 363ad30)
|
Cherry-picked to v9.1.x branch. |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Aug 2, 2021
* asf/9.1.x: (28 commits) Updated ChangeLog Make the rest of InkAPI allocators Proxy Allocated (apache#8106) Added missing milestones and updated slow log report script (apache#8168) Cleans up the code bit, including milliseconds consistency (apache#7989) Note YAML parser library bug, and work-around, in documentation. (apache#7963) Update INSTALL for URLs and version number (apache#8173) ESI plugin documentation updates. (apache#7970) Add a JSON schema for strategies.yaml (apache#7932) ensure hostname_offset is initialized to '0' to indicate null hostname (apache#8162) Fixed compile error with Linux AIO unit test (apache#7958) Enforce case for well known methods (apache#7886) Treat TRACE with body as bad request (apache#7905) Close connection after every bad request for HTTP/1.1 (apache#7885) use sendmsg and recvmsg (apache#7793) Apply log throttling to HTTP/2 session error rate messages (apache#7772) limit m_current_range to max value in RangeTransform (apache#4843) Fix HPACK eviction iterator manipulation (apache#8004) Replace fix assert in error event processing (apache#8058) Adds OCSP support for BoringSSL (apache#7298) .gitignore rules for gcov generated files (apache#8099) ...
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 7, 2022
* asf/master: (763 commits) rate_limit: Add a global hook to rate limit concurrent connections based on SNI (apache#8021) Fix uri_signing unit test for out of source builds (apache#8040) tests: Add conditions for BoringSSL and OpenSSL (apache#8045) change debug tags and make sure sni is printed on certain logs (apache#7673) Doc build in CI: build English docs with -W (apache#8039) When loading async SSL configuration file fails, log SSL error (apache#8036) Doc build: treat warnings as errors only by default (apache#8038) For test async_engine, export all symbols (apache#8037) Fix the server cert reload (apache#8030) Treat Sphinx doc build warnings as errors. (apache#8033) Stablize trace curl test in good_request_after_bad (apache#8032) Doc: Update documentation to build cleanly in Sphinx 3. Require Sphinx 3 or better. (apache#7978) Docs: Fix pre-formatting for ratelimit plugin (apache#7986) Make it slightly harder to dump private keys to logs (apache#8029) tls_bad_alpn: Add an openssl version skip check (apache#8026) per thread jemalloc arena for MADV_DONTDUMP (apache#7501) Adds a new rm-destination, this lets you specify either QUERY or PATH, and be able to drop them from the incoming request (apache#8025) Fix HPACK eviction iterator manipulation (apache#8004) Do not invalidate cached resources upon error responses to unsafe methods (apache#7999) Cleanup SSLUtils (apache#8007) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while investigating #7838. According to https://en.cppreference.com/w/cpp/container/deque/pop_back#:~:text=std%3A%3Adeque%3A%3Apop_back&text=Removes%20the%20last%20element%20of,the%2Dend%20iterator%20is%20invalidated. After pop_back is called "Iterators and references to the erased element are invalidated". In the current logic, the increment is called on the old iterator after pop_back is called.
I'm not 100% sure this is causing our crash. If most of the time only one item is evicted, this case won't happen very often and maybe most of the time you get lucky.
I will get this patched rolled into our build. Even if it does not fix the crash the new logic is safer and looks cleaner.
This closes #7838