Replace assert with warning in error event processing #8058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have been running this in our production. Vinith looked up the messages we received. 50 over our footprint in a 4 hour period. Most of them are just EPOLLERR (0x8). A least one also had EPOLLHUP (0x18). May be ok to just ignore them. Or to pass them along via a write event as this PR does. |
jrushford
reviewed
Jul 13, 2021
zwoop
pushed a commit
that referenced
this pull request
Jul 20, 2021
Replace assert with non-release and process as write event in error event processing (cherry picked from commit 6f32b7c)
|
Cherry-picked to v9.1.x branch. |
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Jul 23, 2021
Replace assert with non-release and process as write event in error event processing (cherry picked from commit 6f32b7c) Conflicts: iocore/net/UnixNet.cc
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Aug 2, 2021
* asf/9.1.x: (28 commits) Updated ChangeLog Make the rest of InkAPI allocators Proxy Allocated (apache#8106) Added missing milestones and updated slow log report script (apache#8168) Cleans up the code bit, including milliseconds consistency (apache#7989) Note YAML parser library bug, and work-around, in documentation. (apache#7963) Update INSTALL for URLs and version number (apache#8173) ESI plugin documentation updates. (apache#7970) Add a JSON schema for strategies.yaml (apache#7932) ensure hostname_offset is initialized to '0' to indicate null hostname (apache#8162) Fixed compile error with Linux AIO unit test (apache#7958) Enforce case for well known methods (apache#7886) Treat TRACE with body as bad request (apache#7905) Close connection after every bad request for HTTP/1.1 (apache#7885) use sendmsg and recvmsg (apache#7793) Apply log throttling to HTTP/2 session error rate messages (apache#7772) limit m_current_range to max value in RangeTransform (apache#4843) Fix HPACK eviction iterator manipulation (apache#8004) Replace fix assert in error event processing (apache#8058) Adds OCSP support for BoringSSL (apache#7298) .gitignore rules for gcov generated files (apache#8099) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in PR #7809.
Replaced the ink_release_assert with a warning so we can gain information about this situation.