Relax key validation of sni.yaml #8549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A potential problem is that you misspell a key for which there is a default value. Then you are running with the default value and will see no problem indication in diags.log. Should we use Warning instead of Note? |
bneradt
previously approved these changes
Dec 14, 2021
masaori335
force-pushed
the
sni-yaml-relax
branch
from
6427bff to
b6111a2
Compare
masaori335
force-pushed
the
sni-yaml-relax
branch
from
b6111a2 to
ebaadb2
Compare
ywkaras
previously approved these changes
Dec 14, 2021
Contributor
Author
|
Please take another look. I followed the advice we talked about at the weekly bug scrab.
|
Contributor
Author
hmm, something wrong with the ci system. |
Contributor
Author
|
All green, it's ready! |
ywkaras
approved these changes
Dec 16, 2021
zwoop
pushed a commit
that referenced
this pull request
Jan 5, 2022
(cherry picked from commit a13fd3d)
zwoop
pushed a commit
that referenced
this pull request
Jan 5, 2022
(cherry picked from commit a13fd3d)
Contributor
|
Cherry-picked to v9.1.x branch. |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog docs: fix fedora install notes and spelling issues (apache#8537) Docs: Fix default value of proxy.config.ssl.handshake_timeout_in (apache#8574) Partial of revert "Cleanup generated LDFLAGS for jemalloc (apache#8285)" (apache#8533) TSUserArg: add value type checking (apache#8550) Relax key validation of sni.yaml (apache#8549) Clear random header value by AIO read error (apache#8559) Fixes macOS arm64 builds (again) (apache#8556) Traffic Dump: Use the correct transaction user index (apache#8548) combo_handler: Initialize User Arg Index in TSRemapInit (apache#8551) backout down parent retry limiting in parent selection and nexthop (apache#8546)
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Jul 26, 2022
(cherry picked from commit a13fd3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the forward compatibility of new keys.
Background
When ATS reads the
sni.yamlfile, it checks the keys of the yaml. This is a bit annoying when you deploy a new key to the env which has old and new versions of ATS.IMO, just ignoring "unknown keys" is fine. Because the function touches the node by defined keys. Any concerns?