Fixes macOS arm64 builds (again) #8556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reverts 43452ca (apache#7662) and fa8b3f9 (apache#7389) and fixes the real issue, where Thread::set_specific was not a pure virtual function, leading to link issues: duplicate symbol 'vtable for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) duplicate symbol 'typeinfo name for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) duplicate symbol 'typeinfo for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o)
Contributor
Author
|
This will partially fix #8554, but also requires a change from our release packager or a change to the brew upstream (and always running |
Contributor
|
@ywkaras volunteered to take a look at this. |
ywkaras
approved these changes
Dec 21, 2021
Contributor
|
Should we leave this out of 9.1.x, to be safe ? |
zwoop
pushed a commit
that referenced
this pull request
Jan 5, 2022
This change reverts 43452ca (#7662) and fa8b3f9 (#7389) and fixes the real issue, where Thread::set_specific was not a pure virtual function, leading to link issues: duplicate symbol 'vtable for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) duplicate symbol 'typeinfo name for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) duplicate symbol 'typeinfo for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) (cherry picked from commit 35d50da)
Contributor
|
Cherry-picked to v9.2.x |
zwoop
pushed a commit
that referenced
this pull request
Feb 11, 2022
This change reverts 43452ca (#7662) and fa8b3f9 (#7389) and fixes the real issue, where Thread::set_specific was not a pure virtual function, leading to link issues: duplicate symbol 'vtable for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) duplicate symbol 'typeinfo name for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) duplicate symbol 'typeinfo for Thread' in: ../iocore/eventsystem/libinkevent.a(Inline.o) ../iocore/eventsystem/libinkevent.a(Thread.o) (cherry picked from commit 35d50da)
Contributor
|
Cherry-picked to v9.1.x branch. |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog docs: fix fedora install notes and spelling issues (apache#8537) Docs: Fix default value of proxy.config.ssl.handshake_timeout_in (apache#8574) Partial of revert "Cleanup generated LDFLAGS for jemalloc (apache#8285)" (apache#8533) TSUserArg: add value type checking (apache#8550) Relax key validation of sni.yaml (apache#8549) Clear random header value by AIO read error (apache#8559) Fixes macOS arm64 builds (again) (apache#8556) Traffic Dump: Use the correct transaction user index (apache#8548) combo_handler: Initialize User Arg Index in TSRemapInit (apache#8551) backout down parent retry limiting in parent selection and nexthop (apache#8546)
13 tasks
Scrumplex
added a commit
to Scrumplex/nixpkgs
that referenced
this pull request
Dec 2, 2024
This fixes the build on macOS 11 Upstream recommends always running autoreconf: apache/trafficserver#8556 (comment) Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
getchoo
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Dec 8, 2024
* trafficserver: 9.2.5 -> 9.2.7 Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> * trafficserver: auto reconfigure broken configure script This fixes the build on macOS 11 Upstream recommends always running autoreconf: apache/trafficserver#8556 (comment) Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> * trafficserver: remove unneeded substitutes Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> --------- Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
nixpkgs-ci bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Dec 8, 2024
* trafficserver: 9.2.5 -> 9.2.7 Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> * trafficserver: auto reconfigure broken configure script This fixes the build on macOS 11 Upstream recommends always running autoreconf: apache/trafficserver#8556 (comment) Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> * trafficserver: remove unneeded substitutes Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> --------- Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> (cherry picked from commit a65078f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts 43452ca (#7662) and fa8b3f9 (#7389) and fixes the
real issue, where Thread::set_specific was not a pure virtual function,
leading to link issues: