combo_handler: Initialize User Arg Index in TSRemapInit #8551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combo_handler plugin did not register its transaction argument index in TSRemapInit, which resulted in using an unregistered id. This generally meant it indexed 0, which could result in it accessing the wrong plugin's transaction user argument data.
randall
approved these changes
Dec 9, 2021
zwoop
pushed a commit
that referenced
this pull request
Jan 5, 2022
The combo_handler plugin did not register its transaction argument index in TSRemapInit, which resulted in using an unregistered id. This generally meant it indexed 0, which could result in it accessing the wrong plugin's transaction user argument data. (cherry picked from commit ed81c93)
zwoop
pushed a commit
that referenced
this pull request
Jan 5, 2022
The combo_handler plugin did not register its transaction argument index in TSRemapInit, which resulted in using an unregistered id. This generally meant it indexed 0, which could result in it accessing the wrong plugin's transaction user argument data. (cherry picked from commit ed81c93)
Contributor
|
Cherry-picked to v9.1.x branch. |
Member
|
If we want this for 8.x can we get a backport? |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog docs: fix fedora install notes and spelling issues (apache#8537) Docs: Fix default value of proxy.config.ssl.handshake_timeout_in (apache#8574) Partial of revert "Cleanup generated LDFLAGS for jemalloc (apache#8285)" (apache#8533) TSUserArg: add value type checking (apache#8550) Relax key validation of sni.yaml (apache#8549) Clear random header value by AIO read error (apache#8559) Fixes macOS arm64 builds (again) (apache#8556) Traffic Dump: Use the correct transaction user index (apache#8548) combo_handler: Initialize User Arg Index in TSRemapInit (apache#8551) backout down parent retry limiting in parent selection and nexthop (apache#8546)
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
…apache#612) The combo_handler plugin did not register its transaction argument index in TSRemapInit, which resulted in using an unregistered id. This generally meant it indexed 0, which could result in it accessing the wrong plugin's transaction user argument data. (cherry picked from commit ed81c93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combo_handler plugin did not register its transaction argument index
in TSRemapInit, which resulted in using an unregistered id. This
generally meant it indexed 0, which could result in it accessing the
wrong plugin's transaction user argument data.