Term standardization: dead/down server -> down server #9582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good to me. On such setting name changes, do we historically do anything on upgrade? I don't think we do. ATS will generate warnings for bad setting names if the dead* version of the settings had been set. |
SolidWallOfCode
previously approved these changes
May 12, 2023
Member
|
@lzx404243 - we MUST have release notes for this. |
Member
|
[approve ci centos] |
lzx404243
force-pushed
the
term-standardization
branch
from
723a051 to
03edc90
Compare
SolidWallOfCode
approved these changes
May 25, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Fix Via header on H3 connections (apache#9758) Add ssrc and surc log fields for server simple/unavail retry counts. (apache#9694) Term standardization: dead/down server -> down server (apache#9582) Fix a crash caused by a HTTP/2 GET request with a body (apache#9738) Add configuration for UDP poll timeout (apache#9733) Fix quic_no_activity_timeout test (apache#9737) Updates to cmake install to get a running ATS from a fresh install (apache#9735) Make config.proxy.http.no_dns_just_forward_to_parent overridable (apache#9728) Fix a potential crash due to use-after-free on QUIC connections (apache#9715) Doc: Clarify that connect ports can have multiple values (apache#9713) Add BRAVO Reader-Writer Lock (apache#9394) Cleanup: Fix format of doc corruption message (apache#9725) Don't build traffic_quic command (apache#9726) Fix protocol version in request Via header (apache#9716) Fix TS_HTTP_REQUEST_TRANSFORM_HOOK Tunnel Processing (apache#9724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7283 records the issue of using
dead serveranddown serverin the configurations interchangeably, which has caused confusion in the field when inspecting issues(e.g. making one wonder the distinction betweendeadanddown). This PR standardizes those terms todown server. The following configuration and metric items(and their documentation) are updated:proxy.config.http.connect_attempts_max_retries_dead_serverbecomesproxy.config.http.connect_attempts_max_retries_down_serverproxy.config.http.connect.dead.policybecomesproxy.config.http.connect.down.policyproxy.process.http.dead_server.no_requestsbecomesproxy.process.http.down_server.no_requestsIn addition to the above, other usage of the term "dead server" and the like has been updated (in hostDB and http).
This resolves #7283.