Fix a potential crash due to use-after-free on QUIC connections #9715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
[approve ci centos] |
bryancall
requested review from
bryancall and
ywkaras
and removed request for
ywkaras
brbzull0
reviewed
May 23, 2023
Contributor
brbzull0
left a comment
brbzull0
left a comment
There was a problem hiding this comment.
out of curiosity, we are not having something like this right?:
[Switching to Thread 0x7fffe78f8700 (LWP 933662)]
0x00005555559df8b7 in Continuation::handleEvent (this=0x7fff8c11faa0, event=2, data=0x555556511a40)
at /home/dmeden/code/git/trafficserver-h3/iocore/eventsystem/I_Continuation.h:227
227 ink_release_assert(!mutex || mutex->thread_holding == this_ethread());
#0 0x00005555559df8b7 in Continuation::handleEvent (this=0x7fff8c11faa0, event=2, data=0x555556511a40)
...
was the crash related to a quiche timeout?
Member
Author
|
Yes, the crash seemed to be related to quiche timeout. If a connection closes in an unexpected way, an ATS event to check connection state remains active in the event queue even after QUICNetVC is freed. I don't remember how the backtrace looked like but it might have been the line which checks continuation's mutex you mentioned above. |
brbzull0
approved these changes
May 23, 2023
Contributor
brbzull0
left a comment
brbzull0
left a comment
There was a problem hiding this comment.
looks good to me! Thanks
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Fix Via header on H3 connections (apache#9758) Add ssrc and surc log fields for server simple/unavail retry counts. (apache#9694) Term standardization: dead/down server -> down server (apache#9582) Fix a crash caused by a HTTP/2 GET request with a body (apache#9738) Add configuration for UDP poll timeout (apache#9733) Fix quic_no_activity_timeout test (apache#9737) Updates to cmake install to get a running ATS from a fresh install (apache#9735) Make config.proxy.http.no_dns_just_forward_to_parent overridable (apache#9728) Fix a potential crash due to use-after-free on QUIC connections (apache#9715) Doc: Clarify that connect ports can have multiple values (apache#9713) Add BRAVO Reader-Writer Lock (apache#9394) Cleanup: Fix format of doc corruption message (apache#9725) Don't build traffic_quic command (apache#9726) Fix protocol version in request Via header (apache#9716) Fix TS_HTTP_REQUEST_TRANSFORM_HOOK Tunnel Processing (apache#9724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this fixes the crash we see on the docs server.