Fix a crash when H3 transaction ends early #9729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
commented
May 23, 2023
| Http3Transaction::state_stream_open(int event, Event *edata) | ||
| { | ||
| // TODO: should check recursive call? | ||
| if (this->_thread != this_ethread()) { |
Member
Author
There was a problem hiding this comment.
Note for reviewers: This block was copied from H2 but thread mismatch should not happen. If it happens, we should fix the code that schedules events on a wrong thread.
brbzull0
reviewed
May 31, 2023
proxy/http3/Http3Transaction.cc
Outdated
| void | ||
| HQTransaction::_unschedule_write_complete_event() | ||
| { | ||
| if (this->_read_complete_event) { |
Contributor
There was a problem hiding this comment.
shouldn't we be checking _write_complete_event?
brbzull0
approved these changes
May 31, 2023
Contributor
brbzull0
left a comment
brbzull0
left a comment
There was a problem hiding this comment.
looks good to me. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #9715 but this one is for H3 layer.