Skip to content

Cmake plugins and install things #9597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmcfarlen merged 6 commits into from
Apr 19, 2023
Merged

Cmake plugins and install things #9597

cmcfarlen merged 6 commits into from
Apr 19, 2023

Conversation

@cmcfarlen
Copy link
Contributor

@cmcfarlen cmcfarlen commented Apr 11, 2023

No description provided.

@cmcfarlen cmcfarlen force-pushed the cmake-install-things branch from 5e0a335 to 13f3602 Compare April 11, 2023 10:33
bneradt
bneradt requested changes Apr 11, 2023
View reviewed changes
CMakeLists.txt Outdated
add_subdirectory(src/traffic_server)
add_subdirectory(plugins)

add_subdirectory(configs)
Copy link
Contributor

@bneradt bneradt Apr 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to configure vscode to add newlines to end of files:
https://stackoverflow.com/a/44704969/629530

Copy link
Contributor Author

@cmcfarlen cmcfarlen Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this for vim, but been using clion lately. I'll look up the equivalent.

bneradt
bneradt reviewed Apr 11, 2023
View reviewed changes
bneradt
bneradt reviewed Apr 11, 2023
View reviewed changes
@bneradt
Copy link
Contributor

bneradt commented Apr 11, 2023

This is great progress. Thanks @cmcfarlen for working on this.

@bneradt bneradt added the Build work related to build configuration or environment label Apr 12, 2023
@bneradt bneradt added this to the 10.0.0 milestone Apr 12, 2023
@cmcfarlen cmcfarlen marked this pull request as ready for review April 17, 2023 16:11
@bryancall bryancall self-requested a review April 17, 2023 22:46
@ywkaras
Copy link
Contributor

ywkaras commented Apr 18, 2023

How does CMake handle installing headers for externally-built plugings? As done here in Makefile.am: https://github.com/apache/trafficserver/blob/master/include/tscpp/api/Makefile.am .

@cmcfarlen cmcfarlen force-pushed the cmake-install-things branch from 9648d9a to 3f547e8 Compare April 19, 2023 19:14
@cmcfarlen
Copy link
Contributor Author

cmcfarlen commented Apr 19, 2023

How does CMake handle installing headers for externally-built plugings? As done here in Makefile.am: https://github.com/apache/trafficserver/blob/master/include/tscpp/api/Makefile.am .

cmake have various forms of the install function that can be used to install header files. Scrutinizing that will have to wait for another cmake PR since I'm mostly updating this "in anger" as needed.

@cmcfarlen cmcfarlen merged commit d40ca1a into apache:master Apr 19, 2023
@cmcfarlen cmcfarlen deleted the cmake-install-things branch April 19, 2023 20:08
@bneradt bneradt added the CMake work related to CMakes scripts or issues label Jun 13, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
a2ba9f3 
* asf/master: (40 commits)
  Change remap filter behavior to match ip_allow.yaml (apache#9631)
  Cleanup: Get rid of dead code from Cache (apache#9621)
  Replace obsolete Debug() macro with Dbg() in SocksProxy.cc. (apache#9613)
  Updates for the new go-httpbin v2.6.0 release. (apache#9633)
  Fix debian symbol not found for test_HttpTransact (apache#9617)
  add traffic_ctl to cmake (apache#9628)
  Fix Proxy Protocol outbound (apache#9632)
  DOC: Fix variable name `proxy.config.exec_thread.autoconfig.enabled`. (apache#9629)
  traffic_ctl: metric monitor. Handle SIGINT to drop collected stats. (apache#9570)
  traffic_ctl: plugin msg command, print out the response from server. (apache#9610)
  Doc: document IP allow filter for remap. (apache#9626)
  Cleanup: Rename d with vol (apache#9619)
  Ensure a reason phrase when sending an HTTP/1 response (apache#9615)
  Cmake plugins and install things (apache#9597)
  quic: Fix session cleanup assert. (apache#9622)
  Enables switching SSL certificates on QUIC with QUICHE (apache#9347)
  Use FetchSM for OCSP HTTP requests (apache#9591)
  Make a couple of the threads configs correct (apache#9604)
  Change submit_and_wait to take ink_hrtime. Fix test_AIO for io_uring. (apache#9555)
  Update build_h3_tools for mac (apache#9608)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bneradt bneradt bneradt approved these changes

@bryancall bryancall Awaiting requested review from bryancall

Assignees

@cmcfarlen cmcfarlen

Labels

Build work related to build configuration or environment CMake work related to CMakes scripts or issues

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cmcfarlen @bneradt @ywkaras