-
Notifications
You must be signed in to change notification settings - Fork 845
Fix debian symbol not found for test_HttpTransact #9617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docker container I am doing the testing in is based off the |
|
It seems like this chunk from proxy/http/Makefile.am is what allows test_HttpTransact to even link in the first place: If the hardening linker flags are specified then the symbols missing are needed for whatever security stuff happens before the code is executed or perhaps it's a problem because lazy binding is disabled. Either way these two linker flags seem to be at odds. There is a similar situation in the http3 directory as well, but these are the only two places that I found that use this flag. As for what to do, I recommend we remove this |
|
I'm the guy who added the ignore-all flag. I tried to link dependent objects in a normal way, but it was too painful and ended up adding the flag. I'm fine with removing the flag if we can run the tests, but we should probably make CI green first, and have the hardening flag one of the GitHub CI jobs so we won't be surprised after merging PRs. |
+1. Once we do whatever fix we agree to with addressing this, I'll configure the debian PR CI to run with |
|
Using the LDADD flags from the traffic_server makefile does work to link this test. Could use that, or start with that and try to prune some back. |
Well, linking everything would work for all tests for sure, but I don't want to lose the hints (objects we currently link and the stubs) we gathered so far. @lzx404243 Can we remove the ignore-all flag if we have these stubs? Or does it still does some work? |
|
@maskit After removing the ignore-all flag, there would be some compile-time errors such as the following: |
|
@lzx404243 Thanks for checking it. I'd take this as it is, but leave the decision to @cmcfarlen . |
f9c9eb1 to
da8eeb5
Compare
|
@cmcfarlen Thanks for your input. I removed the stubs and the |
This reverts commit 8499ae6.
da8eeb5 to
4500b94
Compare
cmcfarlen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
|
@bneradt This has merge conflicts on 9.2.x, can you please make a 9.2.x branch PR please? |
* asf/master: (40 commits) Change remap filter behavior to match ip_allow.yaml (apache#9631) Cleanup: Get rid of dead code from Cache (apache#9621) Replace obsolete Debug() macro with Dbg() in SocksProxy.cc. (apache#9613) Updates for the new go-httpbin v2.6.0 release. (apache#9633) Fix debian symbol not found for test_HttpTransact (apache#9617) add traffic_ctl to cmake (apache#9628) Fix Proxy Protocol outbound (apache#9632) DOC: Fix variable name `proxy.config.exec_thread.autoconfig.enabled`. (apache#9629) traffic_ctl: metric monitor. Handle SIGINT to drop collected stats. (apache#9570) traffic_ctl: plugin msg command, print out the response from server. (apache#9610) Doc: document IP allow filter for remap. (apache#9626) Cleanup: Rename d with vol (apache#9619) Ensure a reason phrase when sending an HTTP/1 response (apache#9615) Cmake plugins and install things (apache#9597) quic: Fix session cleanup assert. (apache#9622) Enables switching SSL certificates on QUIC with QUICHE (apache#9347) Use FetchSM for OCSP HTTP requests (apache#9591) Make a couple of the threads configs correct (apache#9604) Change submit_and_wait to take ink_hrtime. Fix test_AIO for io_uring. (apache#9555) Update build_h3_tools for mac (apache#9608) ...
As reported in #9601, running the unit test
test_HttpTransactresult in the "symbol not found" error on Debian when ATS is configured with theenable-hardeningflag.This PR adds a bunch of stubs to resolve these errors. Suggestions on any cleaner way to resolve this is also welcome :)
This resolves #9601.