Skip to content

Conversation

@brbzull0
Copy link
Contributor

No description provided.

@brbzull0 brbzull0 added Tools traffic_ctl traffic_ctl related work. labels Apr 14, 2023
@brbzull0 brbzull0 added this to the 10.0.0 milestone Apr 14, 2023
@brbzull0 brbzull0 self-assigned this Apr 14, 2023
Copy link
Contributor

@cmcfarlen cmcfarlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the code. It seems the only time the response isn't empty is if there was a parsing error. I'd be cool if there was a way to get data out of a plugin!

@brbzull0
Copy link
Contributor Author

brbzull0 commented Apr 20, 2023

Thanks Chris.

I read through the code. It seems the only time the response isn't empty is if there was a parsing error. I'd be cool if there was a way to get data out of a plugin!

The server can respond with an error like(which unless we call the printer it would never be display):

$ traffic_ctl plugin msg plugin_xyz dump -f rpc
{"jsonrpc": "2.0", "error": {"code": 10, "message": "Unauthorized action", "data": [{"code": 2, "message": "Denied privileged API access for uid=105106 gid=100"}]}, "id": "5a30ae5f-03f4-4d44-ba33-2f51e8a77f82"}
Server Error found:
[10] Unauthorized action
- [2] Denied privileged API access for uid=1001 gid=1001

I'd be cool if there was a way to get data out of a plugin!

You can do this already. A JSON-RPC handler can be located inside a plugin and respond with data to the outside.

@brbzull0 brbzull0 merged commit 0dabc3e into apache:master Apr 20, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (40 commits)
  Change remap filter behavior to match ip_allow.yaml (apache#9631)
  Cleanup: Get rid of dead code from Cache (apache#9621)
  Replace obsolete Debug() macro with Dbg() in SocksProxy.cc. (apache#9613)
  Updates for the new go-httpbin v2.6.0 release. (apache#9633)
  Fix debian symbol not found for test_HttpTransact (apache#9617)
  add traffic_ctl to cmake (apache#9628)
  Fix Proxy Protocol outbound (apache#9632)
  DOC: Fix variable name `proxy.config.exec_thread.autoconfig.enabled`. (apache#9629)
  traffic_ctl: metric monitor. Handle SIGINT to drop collected stats. (apache#9570)
  traffic_ctl: plugin msg command, print out the response from server. (apache#9610)
  Doc: document IP allow filter for remap. (apache#9626)
  Cleanup: Rename d with vol (apache#9619)
  Ensure a reason phrase when sending an HTTP/1 response (apache#9615)
  Cmake plugins and install things (apache#9597)
  quic: Fix session cleanup assert. (apache#9622)
  Enables switching SSL certificates on QUIC with QUICHE (apache#9347)
  Use FetchSM for OCSP HTTP requests (apache#9591)
  Make a couple of the threads configs correct (apache#9604)
  Change submit_and_wait to take ink_hrtime. Fix test_AIO for io_uring. (apache#9555)
  Update build_h3_tools for mac (apache#9608)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools traffic_ctl traffic_ctl related work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants