Add yaml libs reference to HTTP proxy test suite. #9943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jean Baptiste Favre <debian@jbfavre.org> (cherry picked from commit c0c0c80) Conflicts: proxy/http/Makefile.am
Contributor
|
[approve ci] |
Contributor
Author
|
Pretty sure the autest failures are unrelated: |
jpeach
reviewed
Jul 4, 2023
Comment on lines
+163
to
+164
| -lm \ | ||
| @YAMLCPP_LIBS@ |
Contributor
There was a problem hiding this comment.
Suggested change
| -lm \ | |
| @YAMLCPP_LIBS@ | |
| @YAMLCPP_LIBS@ \ | |
| -lm |
BEst of keep -lm last since order matters :)
Contributor
Author
There was a problem hiding this comment.
I'm just a vessel for the PR. This is a backport of #9885 to 9.2.x. We should follow up with a another PR to make it last.
Contributor
|
[approve ci autest] |
Contributor
|
We'll need to pull in a variety of test updates to 9.2.x to work with fedora:38 and OpenSSL 3.0. I can work on that this afternoon. |
Contributor
This should help the 9.2.x branch run the autests: |
bneradt
approved these changes
Jul 6, 2023
zwoop
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Jean Baptiste Favre debian@jbfavre.org
(cherry picked from commit c0c0c80)
Conflicts:
proxy/http/Makefile.am