Skip to content

Add yaml libs reference to HTTP proxy test suite. #9943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwoop merged 1 commit into from
Jul 6, 2023
Merged

Add yaml libs reference to HTTP proxy test suite. #9943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions proxy/http/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,16 @@ test_proxy_http_LDADD = \
$(top_builddir)/mgmt/libmgmt_p.la \
$(top_builddir)/iocore/utils/libinkutils.a \
@HWLOC_LIBS@ \
@LIBCAP@
@LIBCAP@ \
@YAMLCPP_LIBS@

test_PreWarm_CPPFLAGS = \
$(AM_CPPFLAGS) \
-I$(abs_top_srcdir)/tests/include

test_PreWarm_LDADD = \
$(top_builddir)/src/tscore/libtscore.la
$(top_builddir)/src/tscore/libtscore.la \
@YAMLCPP_LIBS@

test_PreWarm_SOURCES = \
unit_tests/test_PreWarm.cc
Expand Down Expand Up @@ -158,7 +160,8 @@ test_HttpTransact_LDADD = \
@LIBZ@ \
@LIBLZMA@ \
@OPENSSL_LIBS@ \
-lm
-lm \
@YAMLCPP_LIBS@
Comment on lines +163 to +164
Copy link
Contributor

@jpeach jpeach Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-lm \
@YAMLCPP_LIBS@
@YAMLCPP_LIBS@ \
-lm

BEst of keep -lm last since order matters :)

Copy link
Contributor Author

@randall randall Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just a vessel for the PR. This is a backport of #9885 to 9.2.x. We should follow up with a another PR to make it last.


test_HttpTransact_SOURCES = \
../../iocore/cache/test/stub.cc \
Expand Down