[Hexagon] Float and quantized dense operators with schedules #12873

joshherr-quic · 2022-09-22T15:32:36Z

This PR implements dense operators for float types and quantized types. The quantized implementation uses floating point numbers for its intermediate compute type, fixed point will be investigated in the future.

float16 accuracy is questionable. Needs further investigation in an actual model (not just a unittest).

tvm-bot · 2022-10-30T23:52:19Z

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Built docs for commit 37de4e4 can be found here.

_{Generated by tvm-bot}

mehrdadh · 2022-11-02T20:37:17Z

@tvm-bot rerun

mehrdadh

Let's wait for this PR and rerun this again. After this PR, please move the test file to slice_op sub directory.
#13271

Also, to help with the pylint with test files, please add the test file to pylint script:
tests/lint/pylint.sh

joshherr-quic · 2022-11-10T03:07:48Z

@tvm-bot rerun

joshherr-quic · 2022-11-10T16:05:21Z

PR is failing for other targets, not sure what is going on.

CC: @mehrdadh

mehrdadh · 2022-11-10T17:28:57Z

allocate_hexagon_array was moved in this PR:#13336
Please rebase and fix imports in your PR

kparzysz-quic · 2022-12-08T16:59:54Z

@tvm-bot rerun

github-actions · 2022-12-08T17:00:11Z

Failed to re-run CI in https://github.com/apache/tvm/actions/runs/3650397411

Traceback (most recent call last):
  File "ci/scripts/github/github_tvmbot.py", line 593, in comment_failure
    raise item
  File "ci/scripts/github/github_tvmbot.py", line 699, in run
    pr.rerun_jenkins_ci()
  File "ci/scripts/github/github_tvmbot.py", line 552, in rerun_jenkins_ci
    post(url, auth=("tvm-bot", TVM_BOT_JENKINS_TOKEN))
  File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 53, in post
    with request.urlopen(req, data) as response:
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 500: Server Error

with response


  
  <!DOCTYPE html><html><head resURL="/static/e3b9d568" data-rooturl="" data-resurl="/static/e3b9d568" data-extensions-available="true" data-unit-test="false" data-imagesurl="/static/e3b9d568/images" data-crumb-header="Jenkins-Crumb" data-crumb-value="8b0f3a6076812477b272301aa611530d3a27d1305f65c004fe1472d435a0fc38b42aab891f382c4b1322d9ac31e90babca33cc5e79c49427bd87c9d455d8a6b5">
    
    

    <title>Jenkins [Jenkins]</title><link rel="stylesheet" href="/static/e3b9d568/jsbundles/styles.css" type="text/css"><link rel="stylesheet" href="/static/e3b9d568/css/responsive-grid.css" type="text/css"><link rel="shortcut icon" href="/static/e3b9d568/favicon.ico" type="image/vnd.microsoft.icon"><script src="/static/e3b9d568/scripts/prototype.js" type="text/javascript"></script><script src="/static/e3b9d568/scripts/behavior.js" type="text/javascript"></script><script src='/adjuncts/e3b9d568/org/kohsuke/stapler/bind.js' type='text/javascript'></script><script src="/static/e3b9d568/scripts/yui/yahoo/yahoo-min.js"></script><script src="/static/e3b9d568/scripts/yui/dom/dom-min.js"></script><script src="/static/e3b9d568/scripts/yui/event/event-min.js"></script><script src="/static/e3b9d568/scripts/yui/animation/animation-min.js"></script><script src="/static/e3b9d568/scripts/yui/dragdrop/dragdrop-min.js"></script><script src="/static/e3b9d568/scripts/yui/container/container-min.js"></script><script src="/static/e3b9d568/scripts/yui/connection/connection-min.js"></script><script src="/static/e3b9d568/scripts/yui/datasource/datasource-min.js"></script><script src="/static/e3b9d568/scripts/yui/autocomplete/autocomplete-min.js"></script><script src="/static/e3b9d568/scripts/yui/menu/menu-min.js"></script><script src="/static/e3b9d568/scripts/yui/element/element-min.js"></script><script src="/static/e3b9d568/scripts/yui/button/button-min.js"></script><script src="/static/e3b9d568/scripts/yui/storage/storage-min.js"></script><script src="/static/e3b9d568/scripts/hudson-behavior.js" type="text/javascript"></script><script src="/static/e3b9d568/scripts/sortable.js" type="text/javascript"></script><link rel="stylesheet" href="/static/e3b9d568/scripts/yui/container/assets/container.css" type="text/css"><link rel="stylesheet" href="/static/e3b9d568/scripts/yui/container/assets/skins/sam/container.css" type="text/css"><link rel="stylesheet" href="/static/e3b9d568/scripts/yui/menu/assets/skins/sam/menu.css" type="text/css"><link rel="search" href="/opensearch.xml" type="application/opensearchdescription+xml" title="Jenkins"><meta name="ROBOTS" content="INDEX,NOFOLLOW"><meta name="viewport" content="width=device-width, initial-scale=1"><script src="/static/e3b9d568/jsbundles/vendors.js" type="text/javascript"></script><script src="/static/e3b9d568/jsbundles/page-init.js" type="text/javascript"></script><script src="/static/e3b9d568/jsbundles/sortable-drag-drop.js" type="text/javascript"></script></head><body data-model-type="hudson.model.Hudson" id="jenkins" class="yui-skin-sam one-column jenkins-2.361.2" data-version="2.361.2"><a href="#skip2content" class="skiplink">Skip to content</a><header id="page-header" class="page-header"><div class="page-header__brand"><div class="logo"><a id="jenkins-home-link" href="/"><img src="/static/e3b9d568/images/svgs/logo.svg" alt="[Jenkins]" id="jenkins-head-icon"><img src="/static/e3b9d568/images/title.svg" alt="Jenkins" width="139" id="jenkins-name-icon" height="34"></a></div><a href="/" class="page-header__brand-link"><img src="/static/e3b9d568/images/svgs/logo.svg" alt="[Jenkins]" class="page-header__brand-image"><span class="page-header__brand-name">Jenkins</span></a></div><div class="searchbox hidden-xs"><form role="search" method="get" name="search" action="/search/" style="position:relative;" class="no-json"><div id="search-box-sizer"></div><div id="searchform"><input role="searchbox" name="q" placeholder="Search" id="search-box" class="main-search__input"><span class="main-search__icon-leading"><svg class="" class="" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" class="" viewBox="0 0 512 512"><title></title><path d="M221.09 64a157.09 157.09 0 10157.09 157.09A157.1 157.1 0 00221.09 64z" fill="none" stroke="currentColor" stroke-miterlimit="10" stroke-width="32"/><path fill="none" stroke="currentColor" stroke-linecap="round" stroke-miterlimit="10" stroke-width="32" d="M338.29 338.29L448 448"/></svg></span><a href="https://www.jenkins.io/redirect/search-box" class="main-search__icon-trailing"><svg class="" class="" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path d="M256 40a216 216 0 10216 216A216 216 0 00256 40z" fill="none" stroke="currentColor" stroke-miterlimit="10" stroke-width="38"/><path d="M200 202.29s.84-17.5 19.57-32.57C230.68 160.77 244 158.18 256 158c10.93-.14 20.69 1.67 26.53 4.45 10 4.76 29.47 16.38 29.47 41.09 0 26-17 37.81-36.37 50.8S251 281.43 251 296" fill="none" stroke="currentColor" stroke-linecap="round" stroke-miterlimit="10" stroke-width="38"/><circle cx="250" cy="360" r="25" fill="currentColor"/></svg></a><div id="search-box-completion" data-search-url="/search/"></div><script src='/adjuncts/e3b9d568/jenkins/views/JenkinsHeader/search-box.js' type='text/javascript'></script></div></form></div><div class="login page-header__hyperlinks"><div id="visible-am-insertion" class="page-header__am-wrapper"></div><div id="visible-sec-am-insertion" class="page-header__am-wrapper"></div><a href="/securityRealm/commenceLogin?from=%2Fjob%2Ftvm-arm%2Fjob%2FPR-12873%2FbuildWithParameters"><b>log in</b></a></div></header><script src="/static/e3b9d568/jsbundles/keyboard-shortcuts.js" type="text/javascript"></script><div id="breadcrumbBar"><script src='/adjuncts/e3b9d568/lib/layout/breadcrumbs.js' type='text/javascript'></script><div class="top-sticker noedge"><div class="top-sticker-inner"><div class="jenkins-breadcrumbs"><ul id="breadcrumbs"><li class="item"><a href="/" class="model-link">Dashboard</a></li><li href="/" class="children"></li></ul><div id="breadcrumb-menu-target"></div></div></div></div></div><div id="page-body" class="clear"><div id="main-panel"><a name="skip2content"></a><h1 style="text-align: center"><img src="/static/e3b9d568/images/rage.svg" width="154" height="179"><span style="font-size:50px"> Oops!</span></h1><div id="error-description"><h2 style="text-align: center">A problem occurred while processing the request.</h2><p style="text-align: center">Logging ID=9261c60e-b83c-49c8-a76c-45b2010f4d00</div></div></div><footer class="page-footer"><div class="container-fluid"><div class="page-footer__flex-row"><div class="page-footer__footer-id-placeholder" id="footer"></div><div class="page-footer__links rest_api hidden-xs"><a href="api/">REST API</a></div><div class="page-footer__links page-footer__links--white jenkins_ver"><a rel="noopener noreferrer" href="https://www.jenkins.io/" target="_blank">Jenkins 2.361.2</a></div></div></div></footer></body></html>

kparzysz-quic · 2022-12-14T18:40:17Z

Ping. The lint issues have been addressed and the PR has been rebased.

kparzysz-quic · 2023-01-10T22:25:58Z

Ping @mehrdadh

…oses" This reverts commit 8fa3ff3.

This reverts commit 9c21e6a.

kparzysz-quic · 2023-01-23T21:56:05Z

@mehrdadh

mehrdadh

sorry for the delay, looks good.
Please address these few comments before we merge it

tests/python/contrib/test_hexagon/topi/slice_op/test_dense_slice.py

…2873) This PR implements dense operators for float types and quantized types. The quantized implementation uses floating point numbers for its intermediate compute type, fixed point will be investigated in the future. float16 accuracy is questionable. Needs further investigation in an actual model (not just a unittest).

joshherr-quic mentioned this pull request Oct 3, 2022

[CI Problem] [Hexagon] Builder failing due to outdated LLVM #12966

Closed

joshherr-quic force-pushed the joshherr/dense branch from 54769df to 329a15c Compare October 6, 2022 01:00

joshherr-quic marked this pull request as draft October 6, 2022 20:24

areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022

joshherr-quic mentioned this pull request Oct 25, 2022

[Hexagon]Pull and build specific LLVM sha for hexagon docker CI #13199

Merged

joshherr-quic marked this pull request as ready for review October 25, 2022 20:21

mehrdadh requested changes Nov 2, 2022

View reviewed changes

joshherr-quic requested a review from mehrdadh November 18, 2022 21:00

kparzysz-quic force-pushed the joshherr/dense branch 2 times, most recently from 3dd8e32 to 34ee486 Compare December 12, 2022 16:25

kparzysz-quic force-pushed the joshherr/dense branch from 34ee486 to a68ddc0 Compare January 10, 2023 16:26

joshherr-quic added 9 commits January 23, 2023 10:17

Float and quantized dense operators with schedules

cd7f08c

Formatting

afd8193

Change var name to conform

3c1613a

Remove redundant function dec

82c28c3

Use transposed weight matrix

6b0fa3f

Use fp32 for dense intermediate computation for accuracy purposes

926044b

TODO comment

9ca4cb8

Revert "Use fp32 for dense intermediate computation for accuracy purp…

016c6a5

…oses" This reverts commit 8fa3ff3.

Use correct type for float bias

1b0433c

joshherr-quic and others added 8 commits January 23, 2023 10:18

Add synr to conda dependencies

c4a8122

Revert "Add synr to conda dependencies"

03d8a21

This reverts commit 9c21e6a.

Formatting

45fdc73

Relax float16 test constraints

de853b2

Remove old assert and reduce number of tests

01bf398

Update comments

e29088e

Move test file

bc0446c

Update imports

4749107

kparzysz-quic force-pushed the joshherr/dense branch from 4fb50fd to 4749107 Compare January 23, 2023 18:22

Formatting

76e8c01

mehrdadh requested changes Jan 23, 2023

View reviewed changes

Remove extra comments

849b842

mehrdadh approved these changes Jan 24, 2023

View reviewed changes

mehrdadh merged commit 127fb1e into apache:main Jan 24, 2023

ysh329 mentioned this pull request Apr 17, 2023

[Release] v0.12.0 Release Candidate Notes #14645

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hexagon] Float and quantized dense operators with schedules #12873

[Hexagon] Float and quantized dense operators with schedules #12873

joshherr-quic commented Sep 22, 2022 •

edited

Loading

tvm-bot commented Oct 30, 2022 •

edited

Loading

mehrdadh commented Nov 2, 2022

mehrdadh left a comment

joshherr-quic commented Nov 10, 2022

joshherr-quic commented Nov 10, 2022

mehrdadh commented Nov 10, 2022

kparzysz-quic commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

kparzysz-quic commented Dec 14, 2022

kparzysz-quic commented Jan 10, 2023

kparzysz-quic commented Jan 23, 2023

mehrdadh left a comment

[Hexagon] Float and quantized dense operators with schedules #12873

[Hexagon] Float and quantized dense operators with schedules #12873

Conversation

joshherr-quic commented Sep 22, 2022 • edited Loading

tvm-bot commented Oct 30, 2022 • edited Loading

mehrdadh commented Nov 2, 2022

mehrdadh left a comment

Choose a reason for hiding this comment

joshherr-quic commented Nov 10, 2022

joshherr-quic commented Nov 10, 2022

mehrdadh commented Nov 10, 2022

kparzysz-quic commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

kparzysz-quic commented Dec 14, 2022

kparzysz-quic commented Jan 10, 2023

kparzysz-quic commented Jan 23, 2023

mehrdadh left a comment

Choose a reason for hiding this comment

joshherr-quic commented Sep 22, 2022 •

edited

Loading

tvm-bot commented Oct 30, 2022 •

edited

Loading