[ZEPPELIN-704] Display elapse time for long running paragraph #862

sagarkulkarni3592 · 2016-04-28T10:17:28Z

What is this PR for?

For long running paragraph, it is hard to know how long it has already been running. We should either have the elapsed time displayed

What type of PR is it?

[Bug Fix ]

Todos

What is the Jira issue?

ZEPPELIN-704 (https://issues.apache.org/jira/browse/ZEPPELIN-704)

How should this be tested?

-Open a note.
-Run a paragraph , It should show you the elapsed time.

Screenshots (if appropriate)

Questions:

Does the licenses files need update?No
Is there breaking changes for older versions?No
Does this needs documentation?No

Leemoonsoo · 2016-04-30T04:17:49Z

Thanks @sagarkulkarni3592 for very useful feature.

It works nicely with 'default' looknfeel. However, 'simple' looknfeel it displays elapsed time above the progress bar on left side. like

Could this be displayed below the progress bar on the right side in 'simple' looknfeel? the same position that "Took XX seconds" message placed.

sagarkulkarni3592 · 2016-05-03T07:23:10Z

@Leemoonsoo Thank you for your suggestion.
I have done the necessary changes to make it appear on the same position that "Took XX seconds" message placed.

…lligned for Simple looknfeel.

Leemoonsoo · 2016-05-04T18:57:29Z

@sagarkulkarni3592 Thanks for taking care.
I tried the last commit and i can see text is displayed on the right corner in 'simple' looknfeel.
However, "Took xx seconds" and "xx seconds elapsed" are still displayed in the different place. Could you make it display at exactly the same place where "Took xx seconds" positioned?

…or-zeppelin into ZEPPELIN-704

sagarkulkarni3592 · 2016-05-10T05:21:41Z

@Leemoonsoo Thanks for the suggestion.
Sorry for the delay. I have done the necessary changes.

Had to change property of Simple.css top: -9px from -13px as it was appearing on the loading blue line.

Is this good?

prabhjyotsingh · 2016-05-10T07:09:10Z

Text floats outside paragraph

…moved ' time' text from 'Last updated by xxx at time xxx'.

sagarkulkarni3592 · 2016-05-10T09:58:51Z

Even after merging the pull request for #848 for issue ZEPPELIN-819, it was showing "Took xx seconds. Last updated by undefined at time XXX".

Fixed this to "Took xx seconds. Last updated by anonymous at time XXX".

sagarkulkarni3592 · 2016-05-10T10:06:24Z

@prabhjyotsingh Thank u for the suggestion about text float.
I have made the necessary changes. Is this ok?

…mple" looknfeel.

prabhjyotsingh · 2016-05-13T10:41:22Z

If there is difference in timezone for client and zeppelin server then UI shows a wrong value.

sagarkulkarni3592 · 2016-05-23T12:13:59Z

@prabhjyotsingh Thank you for the bug. Fixed this using standard ISO time format. Tested with different time zones.

Checkout the time zones.

This also changes the time format (customizable in code) at statement "last updated by xx at ".

Added moment.js : Now, took xx seconds text will show as per moment.js documentattion. Same is the case for elapsed time.

…xtra features using Moment.js.

prabhjyotsingh · 2016-05-23T12:28:33Z

zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js

-    var desc = 'Took ' + (timeMs/1000) + ' seconds. Last updated by ' + user + ' at time ' + dateUpdated + '.';
+    var desc = 'Took '
+    + moment.duration(moment(pdata.dateFinished).diff(moment(pdata.dateStarted))).humanize()
+    + '. Last updated by ' + user + ' at ' + $rootScope.dateToString(dateUpdated) + '.';


Grunt build fails

[INFO] src/app/notebook/paragraph/paragraph.controller.js [INFO] line 979 col 5 Bad line breaking before '+'. [INFO] line 980 col 5 Bad line breaking before '+'.

corneadoug · 2016-05-24T16:25:53Z

I would prefer keeping the elapsed wording, otherwise it doesn't give indications that it is for the running process.

sagarkulkarni3592 · 2016-05-25T05:13:50Z

@corneadoug Thank you for the suggestion.
For a long running process, say running for more than hour, it will show something like "3601 seconds elapsed". The number in seconds does not look good. What will be your suggestion on this?
Should I append "Started" before that, so it looks like, "Started a few seconds ago" or "Started 10 minutes ago"?

corneadoug · 2016-05-25T05:32:05Z

@sagarkulkarni3592 if you follow moment.js documentation
You can use fromNow(true) to remove the ago

"Started a few seconds ago", also looks like a good option

sagarkulkarni3592 · 2016-05-25T05:35:36Z

@corneadoug So, it will be "a few seconds elapsed" or "2 minutes elapsed". It this good?

corneadoug · 2016-05-25T05:39:14Z

@sagarkulkarni3592 "Started 2 minutes ago" looks more gracious :)

…ago.".

sagarkulkarni3592 · 2016-05-25T06:37:34Z

@corneadoug Latest commit have both the changes you suggested. :)

@prabhjyotsingh corrected the test cases. :)

prabhjyotsingh · 2016-05-25T11:36:31Z

Tested, works well. LGTM!

corneadoug · 2016-05-25T19:19:28Z

Tested, Merging if there is no more discussions

bzz · 2016-05-26T07:21:10Z

Merging as it includes HOTFIX for failing Integration Tests

bzz · 2016-05-26T07:25:51Z

@sagarkulkarni3592 could you please check that JIRA issue is assigned to you well?

### What is this PR for? For long running paragraph, it is hard to know how long it has already been running. We should either have the elapsed time displayed ### What type of PR is it? [Bug Fix ] ### Todos ### What is the Jira issue? ZEPPELIN-704 (https://issues.apache.org/jira/browse/ZEPPELIN-704) ### How should this be tested? -Open a note. -Run a paragraph , It should show you the elapsed time. ### Screenshots (if appropriate) ![screen shot 2016-04-28 at 3 46 22 pm](https://cloud.githubusercontent.com/assets/12127192/14882841/71313350-0d58-11e6-9fb5-0704e53f7746.png) ### Questions: * Does the licenses files need update?No * Is there breaking changes for older versions?No * Does this needs documentation?No Author: Sagar Kulkarni <sagarkulkarni3592@gmail.com> Closes apache#862 from sagarkulkarni3592/ZEPPELIN-704 and squashes the following commits: f912504 [Sagar Kulkarni] Corrected the mistake. 192f3f7 [Sagar Kulkarni] Changed the elapsed time string to "Started xx seconds/minutes/hours ago.". 6e1a395 [Sagar Kulkarni] Removed function dateToString and made Moment.js call directly. 5a1cee9 [Sagar Kulkarni] Selenium test failure fixing. 536835a [Sagar Kulkarni] Fixed other build issues - Selenium test failures fixed. 52f2fed [Sagar Kulkarni] Fixing build issue - Selenium test fail fixed. 0d8a68a [Sagar Kulkarni] Merge branch 'master' into ZEPPELIN-704 913515a [Sagar Kulkarni] Corrected the compilation error. b18811f [Sagar Kulkarni] Fixed the timezone difference using standard ISO time format. Added extra features using Moment.js. 93dd602 [Sagar Kulkarni] Merge remote-tracking branch 'origin/master' into ZEPPELIN-704 cb76ed5 [Sagar Kulkarni] Fixed "Text floats outside paragraph" issue in both "default" and "simple" looknfeel. 566da6a [Sagar Kulkarni] ZEPPELIN-819 - Fixed the username from 'undefined' to 'anonymous'. Removed ' time' text from 'Last updated by xxx at time xxx'. 6248eac [Sagar Kulkarni] Merge branch 'master' of https://github.com/sagarkulkarni3592/incubator-zeppelin into ZEPPELIN-704 a991b07 [Sagar Kulkarni] ZEPPELIN-704 Aligned elapsed time message with took xx seconds message 4f64ada [Sagar Kulkarni] ZEPPELIN-704 Display elapse time for long running paragraph - Right alligned for Simple looknfeel. 7c340d4 [Sagar Kulkarni] ZEPPELIN-704 Display elapse time for long running paragraph

### What is this PR for? This bug seems to be produced by #862. Currently a exported notebook is not imported with below error message. ``` ERROR [2016-06-20 17:19:21,797] ({qtp559670971-14} NotebookServer.java[onMessage]:231) - Can't handle message com.google.gson.JsonSyntaxException: 2016-06-20T14:33:31-0700 at com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:81) at com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:66) at com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:41) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:93) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:172) at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:81) at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:60) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:93) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:172) at com.google.gson.Gson.fromJson(Gson.java:791) at org.apache.zeppelin.notebook.Notebook.importNote(Notebook.java:199) at org.apache.zeppelin.socket.NotebookServer.importNote(NotebookServer.java:656) at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:175) at org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56) at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128) at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69) at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65) at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122) at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161) at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309) at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214) at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220) at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258) at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632) at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480) at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635) at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555) at java.lang.Thread.run(Thread.java:745) Caused by: java.text.ParseException: Unparseable date: "2016-06-20T14:33:31-0700" at java.text.DateFormat.parse(DateFormat.java:366) at com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:79) ``` ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? [ZEPPELIN-1028](https://issues.apache.org/jira/browse/ZEPPELIN-1028) ### How should this be tested? 1. Apply this patch (Build the source and restart Zeppelin) 2. Export a notebook and try to import it again 3. It should be imported as before ### Screenshots (if appropriate) With this patch, we can import the below two types of date format notebooks. - Exported after #862 merged : `yyyy-MM-dd'T'HH:mm:ssZ` <img width="289" alt="screen shot 2016-06-22 at 12 18 01 pm" src="https://cloud.githubusercontent.com/assets/10060731/16280468/6ebad710-3874-11e6-9ce6-b38e239649a2.png"> - Exported before #862 merged : `MMM dd, yyyy HH:mm:ss` <img width="288" alt="screen shot 2016-06-22 at 12 17 31 pm" src="https://cloud.githubusercontent.com/assets/10060731/16280459/6a4f256e-3874-11e6-848e-ec1ff6e9b441.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <fbdkdud93@hanmail.net> Closes #1055 from AhyoungRyu/ZEPPELIN-1028 and squashes the following commits: 8f91d2d [AhyoungRyu] Fix class description 829bcae [AhyoungRyu] Rename NotebookImportSerializer -> NotebookImportDeserializer 2dff9bb [AhyoungRyu] Support two date format for backward compatibility 2d8fc66 [AhyoungRyu] Remove new line 7c493bf [AhyoungRyu] Change date format in importNote 479c0d0 [AhyoungRyu] Fix exported notebook importing error (cherry picked from commit 57e0dc8) Signed-off-by: Lee moon soo <moon@apache.org>

### What is this PR for? This bug seems to be produced by #862. Currently a exported notebook is not imported with below error message. ``` ERROR [2016-06-20 17:19:21,797] ({qtp559670971-14} NotebookServer.java[onMessage]:231) - Can't handle message com.google.gson.JsonSyntaxException: 2016-06-20T14:33:31-0700 at com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:81) at com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:66) at com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:41) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:93) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:172) at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:81) at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:60) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:93) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:172) at com.google.gson.Gson.fromJson(Gson.java:791) at org.apache.zeppelin.notebook.Notebook.importNote(Notebook.java:199) at org.apache.zeppelin.socket.NotebookServer.importNote(NotebookServer.java:656) at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:175) at org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56) at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128) at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69) at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65) at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122) at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161) at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309) at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214) at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220) at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258) at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632) at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480) at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635) at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555) at java.lang.Thread.run(Thread.java:745) Caused by: java.text.ParseException: Unparseable date: "2016-06-20T14:33:31-0700" at java.text.DateFormat.parse(DateFormat.java:366) at com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:79) ``` ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? [ZEPPELIN-1028](https://issues.apache.org/jira/browse/ZEPPELIN-1028) ### How should this be tested? 1. Apply this patch (Build the source and restart Zeppelin) 2. Export a notebook and try to import it again 3. It should be imported as before ### Screenshots (if appropriate) With this patch, we can import the below two types of date format notebooks. - Exported after #862 merged : `yyyy-MM-dd'T'HH:mm:ssZ` <img width="289" alt="screen shot 2016-06-22 at 12 18 01 pm" src="https://cloud.githubusercontent.com/assets/10060731/16280468/6ebad710-3874-11e6-9ce6-b38e239649a2.png"> - Exported before #862 merged : `MMM dd, yyyy HH:mm:ss` <img width="288" alt="screen shot 2016-06-22 at 12 17 31 pm" src="https://cloud.githubusercontent.com/assets/10060731/16280459/6a4f256e-3874-11e6-848e-ec1ff6e9b441.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <fbdkdud93@hanmail.net> Closes #1055 from AhyoungRyu/ZEPPELIN-1028 and squashes the following commits: 8f91d2d [AhyoungRyu] Fix class description 829bcae [AhyoungRyu] Rename NotebookImportSerializer -> NotebookImportDeserializer 2dff9bb [AhyoungRyu] Support two date format for backward compatibility 2d8fc66 [AhyoungRyu] Remove new line 7c493bf [AhyoungRyu] Change date format in importNote 479c0d0 [AhyoungRyu] Fix exported notebook importing error

### What is this PR for? It had been pointed out in the mailing list that after #862, the execution time was changed to humanized fashion, while we would want to keep something more precise in that case. This PR is rolling back to the old precise time for execution time. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1161 ### How should this be tested? Run a paragraph, after it is finished, it should show: `Took x seconds.` instead of `Took a few seconds` (or Hours, Minutes, Sec) ### Screenshot ![screen shot 2016-07-13 at 2 19 45 pm](https://cloud.githubusercontent.com/assets/710411/16792626/0ff3ccb8-4905-11e6-89b6-a202944d66b8.png) ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes #1172 from corneadoug/ZEPPELIN-1161 and squashes the following commits: df752bd [Damien CORNEAU] Add licence of new dependency 2c21894 [Damien CORNEAU] Fix jscs errors 9f756e3 [Damien CORNEAU] add moment plugin for duration 935f348 [Damien CORNEAU] Fix jxcs e4f7625 [Damien CORNEAU] Revert seconds ago for execution time

### What is this PR for? It had been pointed out in the mailing list that after #862, the execution time was changed to humanized fashion, while we would want to keep something more precise in that case. This PR is rolling back to the old precise time for execution time. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1161 ### How should this be tested? Run a paragraph, after it is finished, it should show: `Took x seconds.` instead of `Took a few seconds` (or Hours, Minutes, Sec) ### Screenshot ![screen shot 2016-07-13 at 2 19 45 pm](https://cloud.githubusercontent.com/assets/710411/16792626/0ff3ccb8-4905-11e6-89b6-a202944d66b8.png) ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes #1172 from corneadoug/ZEPPELIN-1161 and squashes the following commits: df752bd [Damien CORNEAU] Add licence of new dependency 2c21894 [Damien CORNEAU] Fix jscs errors 9f756e3 [Damien CORNEAU] add moment plugin for duration 935f348 [Damien CORNEAU] Fix jxcs e4f7625 [Damien CORNEAU] Revert seconds ago for execution time (cherry picked from commit dbe5e6c) Signed-off-by: Mina Lee <minalee@apache.org>

### What is this PR for? It had been pointed out in the mailing list that after apache#862, the execution time was changed to humanized fashion, while we would want to keep something more precise in that case. This PR is rolling back to the old precise time for execution time. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1161 ### How should this be tested? Run a paragraph, after it is finished, it should show: `Took x seconds.` instead of `Took a few seconds` (or Hours, Minutes, Sec) ### Screenshot ![screen shot 2016-07-13 at 2 19 45 pm](https://cloud.githubusercontent.com/assets/710411/16792626/0ff3ccb8-4905-11e6-89b6-a202944d66b8.png) ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <corneadoug@gmail.com> Closes apache#1172 from corneadoug/ZEPPELIN-1161 and squashes the following commits: df752bd [Damien CORNEAU] Add licence of new dependency 2c21894 [Damien CORNEAU] Fix jscs errors 9f756e3 [Damien CORNEAU] add moment plugin for duration 935f348 [Damien CORNEAU] Fix jxcs e4f7625 [Damien CORNEAU] Revert seconds ago for execution time

ZEPPELIN-704 Display elapse time for long running paragraph

7c340d4

sagarkulkarni3592 closed this May 3, 2016

sagarkulkarni3592 reopened this May 3, 2016

ZEPPELIN-704 Display elapse time for long running paragraph - Right a…

4f64ada

…lligned for Simple looknfeel.

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch from 48bd8f9 to 4f64ada Compare May 3, 2016 11:24

sagarkulkarni3592 added 2 commits May 9, 2016 11:52

ZEPPELIN-704 Aligned elapsed time message with took xx seconds message

a991b07

Merge branch 'master' of https://github.com/sagarkulkarni3592/incubat…

6248eac

…or-zeppelin into ZEPPELIN-704

ZEPPELIN-819 - Fixed the username from 'undefined' to 'anonymous'. Re…

566da6a

…moved ' time' text from 'Last updated by xxx at time xxx'.

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch 2 times, most recently from f6cd0e8 to a491545 Compare May 10, 2016 11:19

Fixed "Text floats outside paragraph" issue in both "default" and "si…

cb76ed5

…mple" looknfeel.

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch from a491545 to cb76ed5 Compare May 10, 2016 12:28

Merge remote-tracking branch 'origin/master' into ZEPPELIN-704

93dd602

Fixed the timezone difference using standard ISO time format. Added e…

b18811f

…xtra features using Moment.js.

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch from b5303ca to b18811f Compare May 23, 2016 12:16

prabhjyotsingh reviewed May 23, 2016
View reviewed changes

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch from 593d241 to 40db463 Compare May 23, 2016 14:35

sagarkulkarni3592 closed this May 23, 2016

sagarkulkarni3592 reopened this May 23, 2016

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch 2 times, most recently from 88f3b1c to 3c7494d Compare May 23, 2016 16:23

Selenium test failure fixing.

5a1cee9

sagarkulkarni3592 added 2 commits May 25, 2016 11:50

Removed function dateToString and made Moment.js call directly.

6e1a395

Changed the elapsed time string to "Started xx seconds/minutes/hours …

192f3f7

…ago.".

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch 2 times, most recently from 115fe8c to 1dabc5e Compare May 25, 2016 08:49

Corrected the mistake.

f912504

sagarkulkarni3592 force-pushed the ZEPPELIN-704 branch from 1dabc5e to f912504 Compare May 25, 2016 09:54

prabhjyotsingh mentioned this pull request May 26, 2016

[MINOR] switch location of interpreter search input box #913

Closed

asfgit closed this in 2ed0f64 May 26, 2016

This was referenced May 26, 2016

[ZEPPELIN-840] Scalding interpreter that works in hdfs mode #917

Closed

[ZEPPELIN-870] Improvement build and pom normalized #905

Closed

bzz mentioned this pull request May 31, 2016

[ZEPPELIN-926] Set maxClassfileName to 128 #935

Closed

1 task

AhyoungRyu mentioned this pull request Jun 21, 2016

[ZEPPELIN-1028] Fix exported notebook importing error #1055

Closed

corneadoug mentioned this pull request Jul 13, 2016

[Zeppelin-1161] Revert precise execution time #1172

Closed

[ZEPPELIN-704] Display elapse time for long running paragraph #862

[ZEPPELIN-704] Display elapse time for long running paragraph #862

Uh oh!

Conversation

sagarkulkarni3592 commented Apr 28, 2016

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

Leemoonsoo commented Apr 30, 2016

Uh oh!

sagarkulkarni3592 commented May 3, 2016

Uh oh!

Leemoonsoo commented May 4, 2016

Uh oh!

sagarkulkarni3592 commented May 10, 2016

Uh oh!

prabhjyotsingh commented May 10, 2016

Uh oh!

sagarkulkarni3592 commented May 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sagarkulkarni3592 commented May 10, 2016

Uh oh!

prabhjyotsingh commented May 13, 2016

Uh oh!

sagarkulkarni3592 commented May 23, 2016

Uh oh!

prabhjyotsingh May 23, 2016

Choose a reason for hiding this comment

Uh oh!

corneadoug commented May 24, 2016

Uh oh!

sagarkulkarni3592 commented May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corneadoug commented May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sagarkulkarni3592 commented May 25, 2016

Uh oh!

corneadoug commented May 25, 2016

Uh oh!

sagarkulkarni3592 commented May 25, 2016

Uh oh!

prabhjyotsingh commented May 25, 2016

Uh oh!

corneadoug commented May 25, 2016

Uh oh!

bzz commented May 26, 2016

Uh oh!

bzz commented May 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sagarkulkarni3592 commented May 10, 2016 •

edited

Loading

sagarkulkarni3592 commented May 25, 2016 •

edited

Loading

corneadoug commented May 25, 2016 •

edited

Loading

bzz commented May 26, 2016 •

edited

Loading