Skip to content

Conversation

@minahlee
Copy link
Member

What is this PR for?

Make search interpreter input box always to be placed upper than repository information or interpreter creation form.

What type of PR is it?

Improvement

Screenshots (if appropriate)

Before
screen shot 2016-05-24 at 3 54 14 pm

After
screen shot 2016-05-24 at 3 54 24 pm

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@cloverhearts
Copy link
Member

Looks good. +1

@AhyoungRyu
Copy link
Contributor

@minahlee I was thinking about this too. LGTM 👍

@astroshim
Copy link
Contributor

+1

@prabhjyotsingh
Copy link
Contributor

LGTM

@prabhjyotsingh
Copy link
Contributor

Merging this if no more discussion.

@bzz
Copy link
Member

bzz commented May 26, 2016

Guys, what's with CI failure?

We should not be merging PRs in case CI is not green - at least without some investigation and results posted.

If a JIRA issue could be created, linking particular failure with a label flaky-test - that would help PMC to prioritize build stability event more.

What do you think?

@prabhjyotsingh
Copy link
Contributor

@bzz, agreed. I too think this will help in building stability.

and for the error due to which this PR is failing; have seen the same in other PRs as well.

Results :

Tests in error: 
  ZeppelinIT.testSparkInterpreterDependencyLoading:209 » ElementNotVisible Eleme...

Tests run: 14, Failures: 0, Errors: 1, Skipped: 0

And this(#862) fixes it.

@bzz
Copy link
Member

bzz commented May 26, 2016

@prabhjyotsingh thank you for quick research! I think same CI failure happened at least in #905 and #917

Shall we merge #862 first and then rebase this and other PRs on top to make sure issue is addressed?

@prabhjyotsingh
Copy link
Contributor

Yes, perfect, it make sense.

@bzz
Copy link
Member

bzz commented May 26, 2016

Done! @minahlee could you rebase please?

@minahlee minahlee force-pushed the fix/insterpreterSearchPosition branch from 037adeb to fd3a13d Compare May 26, 2016 09:31
@minahlee
Copy link
Member Author

@bzz Rebase is done, the failure seems like related to network issue for downloading spark.

@bzz
Copy link
Member

bzz commented May 27, 2016

Great! If this happens again - we need to look if there is existing issue in JIRA for CI failure under flacky-test label, and if there is none (as with this case) we need to create new one, before merging a PR in question i.e as with this guy ZEPPELIN-890 so further improvements can be properly tracked.

It looks good to merge, if there is no other discussion.

@asfgit asfgit closed this in b304f53 May 28, 2016
@minahlee minahlee deleted the fix/insterpreterSearchPosition branch June 23, 2016 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants