-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[MINOR] switch location of interpreter search input box #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good. +1 |
|
@minahlee I was thinking about this too. LGTM 👍 |
|
+1 |
|
LGTM |
|
Merging this if no more discussion. |
|
Guys, what's with CI failure? We should not be merging PRs in case CI is not green - at least without some investigation and results posted. If a JIRA issue could be created, linking particular failure with a label What do you think? |
|
@bzz, agreed. I too think this will help in building stability. and for the error due to which this PR is failing; have seen the same in other PRs as well. And this(#862) fixes it. |
|
@prabhjyotsingh thank you for quick research! I think same CI failure happened at least in #905 and #917 Shall we merge #862 first and then rebase this and other PRs on top to make sure issue is addressed? |
|
Yes, perfect, it make sense. |
|
Done! @minahlee could you rebase please? |
037adeb to
fd3a13d
Compare
|
@bzz Rebase is done, the failure seems like related to network issue for downloading spark. |
|
Great! If this happens again - we need to look if there is existing issue in JIRA for CI failure under It looks good to merge, if there is no other discussion. |
What is this PR for?
Make search interpreter input box always to be placed upper than repository information or interpreter creation form.
What type of PR is it?
Improvement
Screenshots (if appropriate)
Before

After

Questions: