-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-870] Improvement build and pom normalized #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
who can review this pr? @catap @jonbuffington |
spark-dependencies/pom.xml
Outdated
|
|
||
| <properties> | ||
| <spark.version>1.4.1</spark.version> | ||
| <spark.version>1.6.1</spark.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shijinkui for the contribution. I want to point out that change spark.version here is probably not the good way to make 1.6.1 as a default build. while all other dependency versions are remained for spark 1.4.1.
I think activating profile spark-1.6 by default, could be a possible way to make 1.6.1 default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
|
Thank you for contribution, @shijinkui, would you be willing to create a JIRA issue as well and link it? It is very sound and useful, please see the comments above for more detailed feedback. The only thing that can be improved to merge it faster is - if we could separate it on 2 parts:
that would simplify the review and make things even smoother. |
|
hi, @bzz thanks for review. had add spark-1.6 default active and validate phrase.
|
|
hi, @bzz the bower error, my local compile is ok, how can i continue |
|
@shijinkui I do not think that mentioned fronted build warnings are relevant to CI build failure. Update From the embedded |
|
As #862 is merged - it should fix the CI, so could you please rebase on the latest master and see if that helps? |
|
@bzz have rebased. Failed all for the spark archive download timeout by the url |
|
@shijinkui It becomes green. Could you please trigger it again? |
|
@shijinkui Just close and reopen it. :-) |
|
I agree with @bzz. If your PR has both of parts which change behavior or not, I suggest you divide two seperate PR because of easy review. If you mix them, all reviewers should judge everyline which is normallized part or changing something. I also suggest you contribute changing style at first, and changing behavior is the second one. How about you? |

What is this PR for?
spark.iscachedproperty, used by profile when need download spark dist by download-maven-plugin.What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
ZEPPELIN-870
How should this be tested?
run build command:
export MAVEN_OPTS="-Xmx3g -XX:MaxPermSize=512M -XX:ReservedCodeCacheSize=512M"; mvn clean package -Pbuild-distr -DskipTests -Pspark-1.6 -Phadoop-2.7 -Ppyspark -Pvendor-repo -Dignite.version=1.1.0-incubating -Pscalding -Pspark-dist-cached -Drat.skip=trueQuestions: