Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add permissioned signer functionality #14521

Draft
wants to merge 1 commit into
base: 08-29-create_permissioned_signer_example
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 4, 2024

⏱️ 3h 20m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-unit-coverage 19m 🟩
rust-move-unit-coverage 18m 🟩
rust-cargo-deny 15m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-unit-coverage 14m 🟩
general-lints 14m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-unit-coverage 14m 🟩
rust-move-unit-coverage 11m 🟩
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 8m 🟥
check-dynamic-deps 8m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-unit-coverage 7m 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Sep 4, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @runtian-zhou and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 85.80247% with 23 lines in your changes missing coverage. Please review.

Project coverage is 59.7%. Comparing base (ae32259) to head (4c9f145).

Files with missing lines Patch % Lines
...party/move/move-vm/types/src/values/values_impl.rs 75.0% 13 Missing ⚠️
...-move/framework/src/natives/permissioned_signer.rs 94.2% 3 Missing ⚠️
...rd_party/move/move-compiler-v2/src/plan_builder.rs 50.0% 3 Missing ⚠️
third_party/move/move-vm/types/src/value_serde.rs 40.0% 3 Missing ⚠️
third_party/move/move-core/types/src/value.rs 92.8% 1 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           08-29-create_permissioned_signer_example   #14521     +/-   ##
===========================================================================
- Coverage                                      59.8%    59.7%   -0.1%     
===========================================================================
  Files                                           853      854      +1     
  Lines                                        208243   208380    +137     
===========================================================================
+ Hits                                         124537   124542      +5     
- Misses                                        83706    83838    +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 456f5f4 to 55771fc Compare September 4, 2024 20:29
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 31c9b2c to 6d309ff Compare September 4, 2024 20:30
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 55771fc to 070a951 Compare September 5, 2024 00:41
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6d309ff to 703921b Compare September 5, 2024 00:41
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 070a951 to b832d3d Compare September 9, 2024 07:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 703921b to 48991ff Compare September 9, 2024 07:08
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from b832d3d to 6ddb481 Compare September 9, 2024 07:46
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 48991ff to 906c7c7 Compare September 9, 2024 07:47
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 6ddb481 to 8b92b98 Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 906c7c7 to 350db4c Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 8b92b98 to fa646c8 Compare September 10, 2024 17:24
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 350db4c to dad258f Compare September 10, 2024 17:25
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from fa646c8 to c3aba3a Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from dad258f to 6b4da66 Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from c3aba3a to 50b556b Compare September 12, 2024 01:49
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6b4da66 to b1fd015 Compare September 12, 2024 01:50
@runtian-zhou runtian-zhou mentioned this pull request Sep 12, 2024
21 tasks
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 50b556b to 8cd68d5 Compare September 17, 2024 05:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from b1fd015 to 6592c01 Compare September 17, 2024 05:08
@lightmark lightmark changed the title Implement rust logics for permissioned signer [feature] Add permissioned signer functionality Sep 17, 2024
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch 3 times, most recently from 1835d3d to 42decc7 Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 8cd68d5 to 1b8ce69 Compare September 19, 2024 00:34
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 42decc7 to 6ac9449 Compare September 19, 2024 00:35
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 1b8ce69 to c7fcc0e Compare September 19, 2024 08:08
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6ac9449 to 3ae6a87 Compare September 19, 2024 08:08
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from c7fcc0e to 4340103 Compare October 4, 2024 20:56
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 3ae6a87 to 7fbfa3e Compare October 4, 2024 20:56
@runtian-zhou runtian-zhou force-pushed the 08-29-create_permissioned_signer_example branch from 4340103 to ae32259 Compare October 5, 2024 01:53
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 7fbfa3e to f3015ce Compare October 5, 2024 01:54
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from f3015ce to 4c9f145 Compare October 5, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant