Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission for framework #14605

Open
wants to merge 1 commit into
base: 09-09-add_perimission_checks_to_object
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 12, 2024

⏱️ 2h 55m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-unit-coverage 20m 🟩
rust-move-unit-coverage 19m 🟩
rust-move-unit-coverage 18m 🟩
rust-move-unit-coverage 14m 🟩
rust-cargo-deny 12m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 11m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-unit-coverage 10m 🟩
rust-move-tests 10m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-tests 9m 🟥
rust-move-unit-coverage 9m 🟩
rust-move-tests 9m 🟥
check-dynamic-deps 7m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 3m 🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-cargo-deny 4m 2m +126%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Sep 12, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @runtian-zhou and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.8%. Comparing base (6a446be) to head (e85e2c8).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           09-09-add_perimission_checks_to_object   #14605     +/-   ##
=========================================================================
+ Coverage                                    59.1%    59.8%   +0.7%     
=========================================================================
  Files                                         854      854             
  Lines                                      208380   208380             
=========================================================================
+ Hits                                       123170   124797   +1627     
+ Misses                                      85210    83583   -1627     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lightmark lightmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the initialization with intent code?

@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9037ce3 to 843150a Compare September 17, 2024 05:09
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 843150a to 33a73d7 Compare September 17, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 33a73d7 to 9123ceb Compare September 18, 2024 06:23
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9123ceb to 206e782 Compare September 18, 2024 17:52
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 206e782 to 9c81c83 Compare September 19, 2024 00:35
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 9c81c83 to 75362c4 Compare September 19, 2024 08:09
@rahxephon89 rahxephon89 force-pushed the 09-11-permission_for_framework branch from daea4f8 to 76ad6f0 Compare October 1, 2024 20:12
@rahxephon89 rahxephon89 changed the base branch from 09-09-add_perimission_checks_to_object to main October 1, 2024 20:12
@runtian-zhou runtian-zhou marked this pull request as ready for review October 4, 2024 20:46
@runtian-zhou runtian-zhou changed the base branch from main to 09-09-add_perimission_checks_to_object October 4, 2024 20:57
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 86c07b1 to 0573a7b Compare October 5, 2024 01:54
@runtian-zhou runtian-zhou force-pushed the 09-09-add_perimission_checks_to_object branch from 0573a7b to 6a446be Compare October 5, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants