-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permission for framework #14605
base: 09-09-add_perimission_checks_to_object
Are you sure you want to change the base?
permission for framework #14605
Conversation
⏱️ 2h 55m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @runtian-zhou and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-09-add_perimission_checks_to_object #14605 +/- ##
=========================================================================
+ Coverage 59.1% 59.8% +0.7%
=========================================================================
Files 854 854
Lines 208380 208380
=========================================================================
+ Hits 123170 124797 +1627
+ Misses 85210 83583 -1627 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the initialization with intent code?
9037ce3
to
843150a
Compare
b2c0a3d
to
8ab6836
Compare
843150a
to
33a73d7
Compare
8ab6836
to
fe7cd59
Compare
33a73d7
to
9123ceb
Compare
fe7cd59
to
d48d186
Compare
9123ceb
to
206e782
Compare
d48d186
to
3c1467e
Compare
206e782
to
9c81c83
Compare
3c1467e
to
ac81f59
Compare
9c81c83
to
75362c4
Compare
ac81f59
to
2695494
Compare
daea4f8
to
76ad6f0
Compare
729cd2a
to
638ddbb
Compare
86c07b1
to
0573a7b
Compare
638ddbb
to
68bfbb7
Compare
0573a7b
to
6a446be
Compare
68bfbb7
to
e85e2c8
Compare
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist