-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add perimission checks to object #14582
base: 09-04-add_permission_check_to_account
Are you sure you want to change the base?
add perimission checks to object #14582
Conversation
⏱️ 1h 41m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
da28781
to
006ad4c
Compare
381be20
to
6a1fe6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-04-add_permission_check_to_account #14582 +/- ##
======================================================================
Coverage 59.4% 59.4%
======================================================================
Files 857 857
Lines 210762 210762
======================================================================
Hits 125197 125197
Misses 85565 85565 ☔ View full report in Codecov by Sentry. |
006ad4c
to
ef7abd3
Compare
6a1fe6d
to
9037ce3
Compare
ef7abd3
to
c38c2dd
Compare
9037ce3
to
843150a
Compare
c38c2dd
to
95b6704
Compare
843150a
to
33a73d7
Compare
95b6704
to
7394967
Compare
33a73d7
to
9123ceb
Compare
7394967
to
a091794
Compare
9123ceb
to
206e782
Compare
a091794
to
67163ae
Compare
206e782
to
9c81c83
Compare
67163ae
to
f10a3b3
Compare
9c81c83
to
75362c4
Compare
f10a3b3
to
5c9396f
Compare
75362c4
to
86c07b1
Compare
5c9396f
to
9935539
Compare
86c07b1
to
0573a7b
Compare
9935539
to
b927c02
Compare
0573a7b
to
6a446be
Compare
01c55aa
to
b093be7
Compare
54581c5
to
8d87ba2
Compare
b093be7
to
fecd1c8
Compare
8d87ba2
to
685ae8e
Compare
fecd1c8
to
604c2c3
Compare
685ae8e
to
714595b
Compare
604c2c3
to
268e658
Compare
714595b
to
4b17b0b
Compare
268e658
to
9242526
Compare
4b17b0b
to
ac65e16
Compare
9242526
to
7fc9e54
Compare
ac65e16
to
f892ca9
Compare
7fc9e54
to
78d099a
Compare
f892ca9
to
885aaa8
Compare
78d099a
to
6e7ead9
Compare
let creator_permission_signer = permissioned_signer::signer_from_permissioned_handle(&creator_permission_handle); | ||
|
||
// Grant aaron_permission_signer permission to transfer weapon object | ||
grant_permission(creator, &creator_permission_signer, weapon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment in the test refers to aaron_permission_signer
but the actual variable name used is creator_permission_signer
. The variable name in the comment should be updated to match the implementation for accuracy.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
885aaa8
to
37d819c
Compare
6e7ead9
to
5020648
Compare
37d819c
to
6fee5f3
Compare
5020648
to
3234e44
Compare
6fee5f3
to
9f787c4
Compare
3234e44
to
9d42240
Compare
9f787c4
to
98c30cd
Compare
9d42240
to
00ad379
Compare
98c30cd
to
945343a
Compare
00ad379
to
bacdfc0
Compare
945343a
to
48f64ba
Compare
bacdfc0
to
87b4bd5
Compare
Description
Adds permissioned signer support for object transfers and token/collection mutations in the Aptos Framework. This change introduces new permission types and validation checks to ensure only authorized signers can perform transfers and mutations on objects, tokens and collections.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Added new test cases in object.move and aptos_token.move to verify permissioned signer functionality for transfers and mutations.
Key Areas to Review
Checklist